core/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

index c9b8583d1640aac68f3f0a18009de3587707ad26..3ee53e6cf9f3023149f55145b5516f9ad1222107 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -1538,9 +1538,8 @@ CPDF_Parser::Error CPDF_Parser::StartAsyncParse(IFX_FileRead* pFileAccess) {

FX_FILESIZE dwFirstXRefOffset = m_pSyntax->SavePos();

FX_BOOL bXRefRebuilt = FALSE;

- FX_BOOL bLoadV4 = FALSE;

- if (!(bLoadV4 = LoadCrossRefV4(dwFirstXRefOffset, 0, FALSE)) &&

- !LoadCrossRefV5(&dwFirstXRefOffset, TRUE)) {

+ FX_BOOL bLoadV4 = LoadCrossRefV4(dwFirstXRefOffset, 0, FALSE);

+ if (!bLoadV4 && !LoadCrossRefV5(&dwFirstXRefOffset, TRUE)) {

if (!RebuildCrossRef())

return FORMAT_ERROR;