fpdfsdk/fpdfppo.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address more comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfppo.cpp

diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp

index e15b086f882dd598e69f438b7316e3dec058d618..3691a09ce4c1daea23f86a9c9760f388c18cc810 100644

--- a/fpdfsdk/fpdfppo.cpp

+++ b/fpdfsdk/fpdfppo.cpp

@@ -85,8 +85,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,

CPDF_Array* pKeysArray = pNewPages->GetArrayBy("Kids");

if (!pKeysArray) {

CPDF_Array* pNewKids = new CPDF_Array;

- FX_DWORD Kidsobjnum = -1;

- Kidsobjnum = pDestPDFDoc->AddIndirectObject(pNewKids);

+ FX_DWORD Kidsobjnum = pDestPDFDoc->AddIndirectObject(pNewKids);

pNewPages->SetAt("Kids", new CPDF_Reference(pDestPDFDoc, Kidsobjnum));

pNewPages->SetAt("Count", new CPDF_Number(0));