core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address more comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 121498ccd2e315cf769278a8c611b179f15832b9..6c3ac0c1e949e30154e3b8f8f0191e39d082da74 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -924,7 +924,7 @@ CPDF_Font* CPDF_Document::AddFont(CFX_Font* pFont, int charset, FX_BOOL bVert) {

pFontDict = new CPDF_Dictionary;

CFX_ByteString cmap;

CFX_ByteString ordering;

- int supplement;

+ int supplement = 0;

CPDF_Array* pWidthArray = new CPDF_Array;

switch (charset) {

case FXFONT_CHINESEBIG5_CHARSET:

@@ -936,7 +936,8 @@ CPDF_Font* CPDF_Document::AddFont(CFX_Font* pFont, int charset, FX_BOOL bVert) {

break;

case FXFONT_GB2312_CHARSET:

cmap = bVert ? "GBK-EUC-V" : "GBK-EUC-H";

- ordering = "GB1", supplement = 2;

+ ordering = "GB1";

+ supplement = 2;

pWidthArray->AddInteger(7716);

_InsertWidthArray1(pFont, pEncoding.get(), 0x20, 0x20, pWidthArray);

pWidthArray->AddInteger(814);