Re-enable several MSVC warnings

core/fpdfapi/fpdf_render/fpdf_render_text.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_render/render_int.h"
 
 #include "core/fpdfapi/fpdf_page/pageint.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
@@ skipping 117 matching lines @@
   const CPDF_Type3Char* pChar = m_pFont->LoadChar(charcode);
   if (!pChar || !pChar->m_pBitmap)
     return nullptr;
 
   CFX_DIBitmap* pBitmap = pChar->m_pBitmap;
   CFX_Matrix image_matrix, text_matrix;
   image_matrix = pChar->m_ImageMatrix;
   text_matrix.Set(pMatrix->a, pMatrix->b, pMatrix->c, pMatrix->d, 0, 0);
   image_matrix.Concat(text_matrix);
   CFX_DIBitmap* pResBitmap = NULL;
-  int left, top;
+  int left = 0;
+  int top = 0;
   if (FXSYS_fabs(image_matrix.b) < FXSYS_fabs(image_matrix.a) / 100 &&

[Tom Sepez, 2016/03/16 18:34:58]

Do we know if this is ever false? If we could somehow remove it, the
initializations wouldn't be required.  I can't see how it works otherwise.

[Wei Li, 2016/03/17 02:24:05]

Yes, it could be true or false. Tricky thing here is that |left| is passed by
reference as an output argument in line 170. 

[Tom Sepez, 2016/03/17 16:40:05]

Acknowledged.

       FXSYS_fabs(image_matrix.c) < FXSYS_fabs(image_matrix.d) / 100) {
     int top_line, bottom_line;

[Tom Sepez, 2016/03/16 18:34:58]

nit: one per line, combine with assignments.

[Wei Li, 2016/03/17 02:24:04]

Done.

     top_line = _DetectFirstLastScan(pBitmap, TRUE);
     bottom_line = _DetectFirstLastScan(pBitmap, FALSE);
     if (top_line == 0 && bottom_line == pBitmap->GetHeight() - 1) {
       FX_FLOAT top_y = image_matrix.d + image_matrix.f;
       FX_FLOAT bottom_y = image_matrix.f;
       FX_BOOL bFlipped = top_y > bottom_y;
       if (bFlipped) {
         FX_FLOAT temp = top_y;
         top_y = bottom_y;
         bottom_y = temp;
       }
       pSize->AdjustBlue(top_y, bottom_y, top_line, bottom_line);
       pResBitmap = pBitmap->StretchTo(
           (int)(FXSYS_round(image_matrix.a) * retinaScaleX),
           (int)((bFlipped ? top_line - bottom_line : bottom_line - top_line) *
                 retinaScaleY));
       top = top_line;
       if (image_matrix.a < 0) {
         image_matrix.Scale(retinaScaleX, retinaScaleY);
         left = FXSYS_round(image_matrix.e + image_matrix.a);
       } else {
         left = FXSYS_round(image_matrix.e);
       }
     } else {

[Tom Sepez, 2016/03/16 18:34:58]

nit: empty else.

[Wei Li, 2016/03/17 02:24:04]

Done.

     }
   }
   if (!pResBitmap) {
     image_matrix.Scale(retinaScaleX, retinaScaleY);
     pResBitmap = pBitmap->TransformTo(&image_matrix, left, top);
   }
   if (!pResBitmap) {
     return NULL;
   }
   CFX_GlyphBitmap* pGlyph = new CFX_GlyphBitmap;
@@ skipping 603 matching lines @@
     matrix.Concat(font_size, 0, 0, font_size, charpos.m_OriginX,
                   charpos.m_OriginY);
     path.m_Path.New()->Append(pPath, &matrix);
     path.m_Matrix = *pTextMatrix;
     path.m_bStroke = bStroke;
     path.m_FillType = bFill ? FXFILL_WINDING : 0;
     path.CalcBoundingBox();
     ProcessPath(&path, pObj2Device);
   }
 }