Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1801363006: Adding callback for finished property animations. (Closed)

Created:
4 years, 9 months ago by pedro (no code reviews)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mdjones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding callback for finished property animations. This CL extends the ChromeAnimation class to notify Animatable interfaces that a particular property animation has finished. BUG= Committed: https://crrev.com/4107f387c09d36eb24f304e2bc33ec82410bdd9a Cr-Commit-Position: refs/heads/master@{#381854}

Patch Set 1 #

Patch Set 2 : Only firing when an individual property finishes #

Patch Set 3 : Adding unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelAnimation.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchIconSpriteControl.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPeekPromoControl.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java View 1 6 chunks +23 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/CompositorButton.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimationTest.java View 1 2 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pedro (no code reviews)
Hey David, please take a look at this change. Based on our offline discussion, I ...
4 years, 9 months ago (2016-03-18 00:10:04 UTC) #3
David Trainor- moved to gerrit
like the test thanks! :) lgtm!
4 years, 9 months ago (2016-03-18 00:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801363006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801363006/40001
4 years, 9 months ago (2016-03-18 00:22:48 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 00:50:52 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:53:34 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4107f387c09d36eb24f304e2bc33ec82410bdd9a
Cr-Commit-Position: refs/heads/master@{#381854}

Powered by Google App Engine
This is Rietveld 408576698