Fix bug of input.ime.onKeyEvent on Linux.

When there is an IME extension listening on input.ime.onKeyEvent, the key event will be passed to the extension before the OS handling it, and  ProcessKeyEventDone() will be called after the extension calls input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be excused in different orders. The current implementation has bugs as the variables in system such as |composition_changed_| and |result_text_| will be changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone() in InputMethodAuraLinux to recover the passed environment.

BUG=517773
TEST=None

Committed: https://crrev.com/be0623024074fe925eb82e7956e75f897f3fa204
Cr-Commit-Position: refs/heads/master@{#381671}

[Azure Wei, 2016-03-17 06:30:23]

Description was changed from

==========
Fix bug of input.ime.onKeyEvent on Linux.

BUG=517773
TEST=None
==========

to

==========
When there is an IME extension listening on input.ime.onKeyEvent, the key event
will be passed to the extension before the OS handling it, and 
ProcessKeyEventDone() will be called after the extension calls
input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be
excused in different orders. The current implementation has bugs as the
variables in system such as |composition_changed_| and |result_text_| will be
changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated
when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone()
in InputMethodAuraLinux to recover the passed environment. 
 

BUG=517773
TEST=None
==========

[Azure Wei, 2016-03-17 06:30:23]

azurewei@chromium.org changed reviewers:
+ shuchen@chromium.org

[Azure Wei, 2016-03-17 06:31:05]

Please review this cl! Thank you!

[Shu Chen, 2016-03-17 06:37:09]

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
File ui/base/ime/input_method_auralinux.cc (right):

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
ui/base/ime/input_method_auralinux.cc:110: filtered, composition_changed_,
composition_, result_text_);
I think this is wrong.
Please consider why the KeyEvent needs to be a pointer with base::Owned. You may
need to do the same for the |composition_| & |result_text_|.

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
File ui/base/ime/input_method_auralinux.h (right):

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
ui/base/ime/input_method_auralinux.h:64: void
ProcessKeyEventByEngineDone(ui::KeyEvent* event,
please add comment why this method is necessary.

[Azure Wei, 2016-03-17 07:02:37]

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
File ui/base/ime/input_method_auralinux.cc (right):

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
ui/base/ime/input_method_auralinux.cc:110: filtered, composition_changed_,
composition_, result_text_);
On 2016/03/17 06:37:08, Shu Chen wrote:
> I think this is wrong.
> Please consider why the KeyEvent needs to be a pointer with base::Owned. You
may
> need to do the same for the |composition_| & |result_text_|.

Done.

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
File ui/base/ime/input_method_auralinux.h (right):

https://codereview.chromium.org/1801363005/diff/1/ui/base/ime/input_method_au...
ui/base/ime/input_method_auralinux.h:64: void
ProcessKeyEventByEngineDone(ui::KeyEvent* event,
On 2016/03/17 06:37:08, Shu Chen wrote:
> please add comment why this method is necessary.

Done.

[Shu Chen, 2016-03-17 07:11:56]

lgtm

[Azure Wei, 2016-03-17 07:30:33]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-03-17 07:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from shuchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1801363005/#ps80001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-03-17 07:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801363005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801363005/80001

[commit-bot: I haz the power, 2016-03-17 08:13:36]

Description was changed from

==========
When there is an IME extension listening on input.ime.onKeyEvent, the key event
will be passed to the extension before the OS handling it, and 
ProcessKeyEventDone() will be called after the extension calls
input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be
excused in different orders. The current implementation has bugs as the
variables in system such as |composition_changed_| and |result_text_| will be
changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated
when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone()
in InputMethodAuraLinux to recover the passed environment. 
 

BUG=517773
TEST=None
==========

to

==========
When there is an IME extension listening on input.ime.onKeyEvent, the key event
will be passed to the extension before the OS handling it, and 
ProcessKeyEventDone() will be called after the extension calls
input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be
excused in different orders. The current implementation has bugs as the
variables in system such as |composition_changed_| and |result_text_| will be
changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated
when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone()
in InputMethodAuraLinux to recover the passed environment. 
 

BUG=517773
TEST=None
==========

[commit-bot: I haz the power, 2016-03-17 08:13:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-17 08:31:27]

Description was changed from

==========
When there is an IME extension listening on input.ime.onKeyEvent, the key event
will be passed to the extension before the OS handling it, and 
ProcessKeyEventDone() will be called after the extension calls
input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be
excused in different orders. The current implementation has bugs as the
variables in system such as |composition_changed_| and |result_text_| will be
changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated
when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone()
in InputMethodAuraLinux to recover the passed environment. 
 

BUG=517773
TEST=None
==========

to

==========
When there is an IME extension listening on input.ime.onKeyEvent, the key event
will be passed to the extension before the OS handling it, and 
ProcessKeyEventDone() will be called after the extension calls
input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be
excused in different orders. The current implementation has bugs as the
variables in system such as |composition_changed_| and |result_text_| will be
changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated
when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone()
in InputMethodAuraLinux to recover the passed environment.

BUG=517773
TEST=None

Committed: https://crrev.com/be0623024074fe925eb82e7956e75f897f3fa204
Cr-Commit-Position: refs/heads/master@{#381671}
==========

[commit-bot: I haz the power, 2016-03-17 08:31:28]

Patchset 5 (id:??) landed as
https://crrev.com/be0623024074fe925eb82e7956e75f897f3fa204
Cr-Commit-Position: refs/heads/master@{#381671}