Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1801363003: Add a $joinedDescendants output specifier. (Closed)

Created:
4 years, 9 months ago by David Tseng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a $joinedDescendants output specifier. In some live regions, text gets separated into chunks but should rather be concatinated. The makes the speech natural and not pause after each chunk. TEST=chromevox_tests Output*.Join* Committed: https://crrev.com/a8fd41ad696a334b754022acab2f5f3f6f2528d0 Cr-Commit-Position: refs/heads/master@{#382149}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
David Tseng
4 years, 9 months ago (2016-03-16 18:34:50 UTC) #3
dmazzoni
lgtm
4 years, 9 months ago (2016-03-16 18:36:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801363003/1
4 years, 9 months ago (2016-03-16 18:36:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/140607)
4 years, 9 months ago (2016-03-16 19:18:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801363003/1
4 years, 9 months ago (2016-03-18 23:13:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801363003/20001
4 years, 9 months ago (2016-03-18 23:52:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 00:39:30 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:41:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8fd41ad696a334b754022acab2f5f3f6f2528d0
Cr-Commit-Position: refs/heads/master@{#382149}

Powered by Google App Engine
This is Rietveld 408576698