Issue 1801313003: [M50 Merge] Disable Find-In-Page buttons when no text is entered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1801313003: [M50 Merge] Disable Find-In-Page buttons when no text is entered (Closed)

Created:
4 years, 9 months ago by msw

Modified:
4 years, 9 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[M50 Merge] Disable Find-In-Page buttons when no text is entered This CL fixes a regression caused by https://crrev.com/1660273003 which enables the buttons of the Find-In-Page bar even if no text is entered or no search was issued yet. R=msw@chromium.org BUG=594097 TEST=FindInPageTest.ButtonsDisabledWithoutText Review URL: https://codereview.chromium.org/1785033004 Cr-Commit-Position: refs/heads/master@{#381074} (cherry picked from commit afc0733e0630499bea163c4f3cf826c945e7baaf) Committed: https://chromium.googlesource.com/chromium/src/+/820c22f3b79c9af3f6c6c876ae515ec65606a43b

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
M	chrome/browser/ui/views/find_bar_host.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_views_interactive_uitest.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

msw

4 years, 9 months ago (2016-03-15 20:42:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
820c22f3b79c9af3f6c6c876ae515ec65606a43b.