Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1801313002: Switch microtasks checks from V8_ENABLE_CHECKS to DEBUG to work with dcheck_always_on. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switch microtasks checks from V8_ENABLE_CHECKS to DEBUG to work with dcheck_always_on. BUG=chromium:594974 LOG=N Committed: https://crrev.com/5a476db04a1a4179bb1e1461ad9481e48f75a9bb Cr-Commit-Position: refs/heads/master@{#34909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/api.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Adam, could you please take a look? Most chromium bots run with dcheck_always_on instead of ...
4 years, 9 months ago (2016-03-15 19:22:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801313002/1
4 years, 9 months ago (2016-03-15 19:23:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 19:59:19 UTC) #6
adamk
lgtm
4 years, 9 months ago (2016-03-15 20:29:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801313002/1
4 years, 9 months ago (2016-03-18 23:41:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 00:20:06 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:20:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a476db04a1a4179bb1e1461ad9481e48f75a9bb
Cr-Commit-Position: refs/heads/master@{#34909}

Powered by Google App Engine
This is Rietveld 408576698