Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1801293005:
Fix cr.exportPath()'s @return signature so the result can be used (Closed)
|
Created:
4 years, 9 months ago by Dan Beam Modified:
4 years, 9 months ago Reviewers:
dpapad CC:
chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix cr.exportPath()'s @return signature so the result can be used
R=dpapad@chromium.org
BUG=none
Committed: https://crrev.com/4ce0d0b4cc00530167301f734c358797386b52ab
Cr-Commit-Position: refs/heads/master@{#381831}
Patch Set 1 #Patch Set 2 : todo #
Total comments: 2
Patch Set 3 : asdf #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== MD Settings: fix cr.exportPath()'s @return signature so we can use the result Also, update the Closure Compiler pass to more accurately represent what this code is doing. R=tbreisacher@chromium.org BUG=none ========== to ========== MD Settings: fix cr.exportPath()'s @return signature so we can use the result Also, update the Closure Compiler pass to more accurately represent what this code is doing. R=dpapad@chromium.org BUG=none ==========
dbeam@chromium.org changed reviewers: + dpapad@chromium.org - tbreisacher@chromium.org
Description was changed from ========== MD Settings: fix cr.exportPath()'s @return signature so we can use the result Also, update the Closure Compiler pass to more accurately represent what this code is doing. R=dpapad@chromium.org BUG=none ========== to ========== MD Settings: fix cr.exportPath()'s @return signature so we can use the result R=dpapad@chromium.org BUG=none ==========
Description was changed from ========== MD Settings: fix cr.exportPath()'s @return signature so we can use the result R=dpapad@chromium.org BUG=none ========== to ========== MD Settings: fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ==========
lgtm LGTM. Also, could you provide some more context on what problem is this solving, or why is it related to MD Settings specifically? (either in CL description or in a related bug maybe). https://codereview.chromium.org/1801293005/diff/20001/ui/webui/resources/js/c... File ui/webui/resources/js/cr.js (right): https://codereview.chromium.org/1801293005/diff/20001/ui/webui/resources/js/c... ui/webui/resources/js/cr.js:29: * a reference to the ui dictionary property of window.cr). Nit: Either put "i.e." within the parentheses, or remove the parentheses? Also, s/return the a/return a
Description was changed from ========== MD Settings: fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ========== to ========== Fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ==========
On 2016/03/17 18:47:50, dpapad wrote:
> lgtm
>
> LGTM.
>
> Also, could you provide some more context on what problem is this solving, or
> why is it related to MD Settings specifically? (either in CL description or in
a
> related bug maybe).
removed the "MD Settings: " prefix. I was generally hoping to be able to do
something like:
/** @type {boolean} */
cr.exportPath('settings').myThingBlahNotifyForTesting;
Polymer({
...
properties: {
blah: {
...
notify: settings.myThingBlahNotifyForTesting,
},
},
});
current one must do:
cr.exportPath('settings');
/** @type {boolean} */
settings.myThingBlahNotifyForTesting;
which is aight but not as succint.
https://codereview.chromium.org/1801293005/diff/20001/ui/webui/resources/js/c... File ui/webui/resources/js/cr.js (right): https://codereview.chromium.org/1801293005/diff/20001/ui/webui/resources/js/c... ui/webui/resources/js/cr.js:29: * a reference to the ui dictionary property of window.cr). On 2016/03/17 18:47:49, dpapad wrote: > Nit: Either put "i.e." within the parentheses, or remove the parentheses? > > Also, s/return the a/return a Done.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/1801293005/#ps40001 (title: "asdf")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801293005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801293005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801293005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801293005/40001
Message was sent while issue was closed.
Description was changed from ========== Fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ========== to ========== Fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none ========== to ========== Fix cr.exportPath()'s @return signature so the result can be used R=dpapad@chromium.org BUG=none Committed: https://crrev.com/4ce0d0b4cc00530167301f734c358797386b52ab Cr-Commit-Position: refs/heads/master@{#381831} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4ce0d0b4cc00530167301f734c358797386b52ab Cr-Commit-Position: refs/heads/master@{#381831} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
