Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801293003: DevTools: Extract TargetManager into its own file (Closed)

Created:
4 years, 9 months ago by paulirish
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Extract TargetManager into its own file BUG= Committed: https://crrev.com/ff4e8462ee238fc59785c0feec9b4614ef0cb126 Cr-Commit-Position: refs/heads/master@{#381594}

Patch Set 1 #

Patch Set 2 : targetmanager.js #

Total comments: 2

Patch Set 3 : only public interfaces for target properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -635 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 3 chunks +9 lines, -379 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 2 5 chunks +37 lines, -256 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
paulirish
ptal
4 years, 9 months ago (2016-03-16 04:02:45 UTC) #2
pfeldman
One nit, otherwise lgtm https://codereview.chromium.org/1801293003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right): https://codereview.chromium.org/1801293003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js#newcode266 third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:266: var model = target._modelByConstructor.get(listeners[i].modelClass); This ...
4 years, 9 months ago (2016-03-16 19:14:37 UTC) #3
paulirish
all set. https://codereview.chromium.org/1801293003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right): https://codereview.chromium.org/1801293003/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js#newcode266 third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:266: var model = target._modelByConstructor.get(listeners[i].modelClass); On 2016/03/16 19:14:36, ...
4 years, 9 months ago (2016-03-16 22:55:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801293003/40001
4 years, 9 months ago (2016-03-16 22:59:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 00:07:47 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 00:09:33 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ff4e8462ee238fc59785c0feec9b4614ef0cb126
Cr-Commit-Position: refs/heads/master@{#381594}

Powered by Google App Engine
This is Rietveld 408576698