Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1801293002: Lint SpdySession. (Closed)

Created:
4 years, 9 months ago by Bence
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lint SpdySession. git cl lint told me to: * include <vector> for vector, * mark single argument constructor explicit, * leave space before '('. Codesearch told me that SpdySession::pool_ is never set to nullptr, removing incorrect comment. BUG= Committed: https://crrev.com/3f976f86c1f70b8150cc56b4899859bbb20e5b1d Cr-Commit-Position: refs/heads/master@{#381553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/spdy/spdy_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan: PTAL, and if LGTY, please commit. Thank you.
4 years, 9 months ago (2016-03-16 00:57:12 UTC) #2
Ryan Hamilton
lgtm
4 years, 9 months ago (2016-03-16 20:30:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801293002/1
4 years, 9 months ago (2016-03-16 20:31:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 21:39:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f976f86c1f70b8150cc56b4899859bbb20e5b1d Cr-Commit-Position: refs/heads/master@{#381553}
4 years, 9 months ago (2016-03-16 21:42:09 UTC) #8
Bence
4 years, 9 months ago (2016-03-17 01:22:08 UTC) #9
Message was sent while issue was closed.
On 2016/03/16 21:42:09, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3f976f86c1f70b8150cc56b4899859bbb20e5b1d
> Cr-Commit-Position: refs/heads/master@{#381553}

Thank you.

Powered by Google App Engine
This is Rietveld 408576698