Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801273003: Suzero. Refactors dependencies in Makefile.standalone. (Closed)

Created:
4 years, 9 months ago by John
Modified:
4 years, 9 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suzero. Refactors dependencies in Makefile.standalone. Uses the compiler's frontend -MD -MP options to auto-generate make dependencies. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=70e3f1cd240b4ca321545745abbce0cd5a0ca718

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M Makefile.standalone View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
John
4 years, 9 months ago (2016-03-15 21:53:03 UTC) #2
Jim Stichnoth
LGTM, thanks!!! https://codereview.chromium.org/1801273003/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1801273003/diff/1/Makefile.standalone#newcode253 Makefile.standalone:253: $(STDLIB_FLAGS) -MP -MD Can these two additions ...
4 years, 9 months ago (2016-03-15 23:43:58 UTC) #3
John
https://codereview.chromium.org/1801273003/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1801273003/diff/1/Makefile.standalone#newcode253 Makefile.standalone:253: $(STDLIB_FLAGS) -MP -MD On 2016/03/15 23:43:58, stichnot wrote: > ...
4 years, 9 months ago (2016-03-16 11:13:40 UTC) #4
John
4 years, 9 months ago (2016-03-16 11:20:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
70e3f1cd240b4ca321545745abbce0cd5a0ca718 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698