Set rebaseline bot name/email in chromium repo via git config.

Set rebaseline bot name/email in chromium repo via git config.

Remove --commit-author from the bot config as it's insufficient for the full
rebaseline bot flow. Will remove support for the flag from script itself once we
confirm it's not going to be used.

BUG=594817
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299297

[wkorman, 2016-03-15 18:22:04]

wkorman@chromium.org changed reviewers:
+ agable@chromium.org, dpranke@chromium.org

[wkorman, 2016-03-15 18:22:05]

I manually edited the json expectations. Is there a script or something I can
run to generate them for me, and how to run the tests?

[agable, 2016-03-15 18:35:15]

On 2016/03/15 at 18:22:05, wkorman wrote:
> I manually edited the json expectations. Is there a script or something I can
run to generate them for me, and how to run the tests?

`./scripts/slave/unittest/recipe_simulation_test.py train`

[Dirk Pranke, 2016-03-15 18:43:46]

On 2016/03/15 18:35:15, agable wrote:
> On 2016/03/15 at 18:22:05, wkorman wrote:
> > I manually edited the json expectations. Is there a script or something I
can
> run to generate them for me, and how to run the tests?
> 
> `./scripts/slave/unittest/recipe_simulation_test.py train`

We should consider adding these instructions to the presubmit error message,
maybe ...

[wkorman, 2016-03-15 18:47:01]

Thanks, updated the expectations, PTAL.

[agable, 2016-03-15 18:51:16]

lgtm

[wkorman, 2016-03-15 18:57:59]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-03-15 18:58:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801213002/20001

[commit-bot: I haz the power, 2016-03-15 19:02:06]

Description was changed from

==========
Set rebaseline bot name/email in chromium repo via git config.

Remove --commit-author from the bot config as it's insufficient for the full
rebaseline bot flow. Will remove support for the flag from script itself once we
confirm it's not going to be used.

BUG=594817
==========

to

==========
Set rebaseline bot name/email in chromium repo via git config.

Remove --commit-author from the bot config as it's insufficient for the full
rebaseline bot flow. Will remove support for the flag from script itself once we
confirm it's not going to be used.

BUG=594817

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299297
==========

[commit-bot: I haz the power, 2016-03-15 19:02:07]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299297

[Dirk Pranke, 2016-03-15 22:34:44]

Can we use the --author flag to `git commit` from inside webkitpy rather than
messing with the git config?

[wkorman, 2016-03-15 22:49:34]

On 2016/03/15 at 22:34:44, dpranke wrote:
> Can we use the --author flag to `git commit` from inside webkitpy rather than
messing with the git config?

In theory, that's an alternate approach I essentially mentioned in
http://crbug.com/594817 see bullet 2 in the opening comment, and also solicited
input on approach at http://crbug.com/519124#c50

Note that we already tried this in part with http://crrev.com/1784923002 which
led to http://crbug.com/589140#c28. I believe one or more issues are at hand
including:

- AFAICT the initial 'git commit' of the local changes, before attempting to
land, are not using the right author despite our passing them as params. I am
guessing this is a priority issue, that since the repo's git config has the
user.name/email set to chrome-bot from the get-go in the local repo's
.git/config, that takes precedence over the command line arguments. Per szager@
comment in http://crbug.com/589140#c28 and http://crbug.com/589140#c29, it
appears from git man page that env vars have first precedence, so we could use
those, which would require our reworking script to take name/email as separate
inputs since currently we pass them conjoined.

- Secondarily, we may need to teach 'git cl land' to allow passing
author/committer name/email and including in its env as well, since it runs a
cherry pick and I'm guessing that would behave precedence wise similarly to
above.

- Stepping back, it seems not unreasonable to me given the sole purpose of this
bot and checkout is to run rebaselines, to just explicitly set the name/email
before we run the script and have all actions based on that, rather than doing
above work/exploration changes for this sole purpose.

Open to discussion as always.

[Dirk Pranke, 2016-03-15 22:59:43]

That's right, I forgot we had more-or-less tried this. 

I think I would've expanded on the comment to refer to the bug and why --author
doesn't work
and we have to modify the config instead, then.

lgtm .