src/compiler.cc - Issue 1801203002: Parser: Make skipping HTML comments optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1801203002: Parser: Make skipping HTML comments optional. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index aff7f48513a26e01cbc513fe9bc70ad2c106154d..65e29aa220c7e1c8a92c070f604d0a1698ce30e8 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -1666,6 +1666,11 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfoForScript(

info.PrepareForSerializing();

}

+ bool ignore = script_name.is_null() ||

vogelheim 2016/03/15 18:22:59 This is... strange. Should this alternatively go

jochen (gone - plz use gerrit) 2016/03/15 18:36:08 the embedder should tell us whether or not to igno

+ (script_name->IsString() &&

+ Handle<String>::cast(script_name)->length() == 0);

+ parse_info.set_ignore_html_comments(ignore);

parse_info.set_language_mode(

static_cast<LanguageMode>(info.language_mode() | language_mode));

result = CompileToplevel(&info);

« no previous file with comments | « no previous file | src/parsing/parser.h » ('j') | no next file with comments »