Parser: Make skipping HTML comments optional.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 987 matching lines @@
 };
 
 
 /**
  * The optional attributes of ScriptOrigin.
  */
 class ScriptOriginOptions {
  public:
   V8_INLINE ScriptOriginOptions(bool is_embedder_debug_script = false,
                                 bool is_shared_cross_origin = false,
-                                bool is_opaque = false)
+                                bool is_opaque = false,
+                                bool is_skip_html_comments = true)

[jochen (gone - plz use gerrit), 2016/03/18 10:50:29]

can you drop the "is" prefix? Just skip_html_comments.

Eventually, it would be nice if "false" was the default..  maybe

#ifdef V8_IMMINENT_DEPRECATION_WARNINGS
 V8_INLINE ScriptOriginOptions(...
                               bool is_skip_html_comments = false)
#else
 V8_INLINE ScriptOriginOptions(...
                               bool is_skip_html_comments = true)
#endif

[vogelheim, 2016/03/18 11:19:53]

Done.
As discussed, I'm less sure about this. What I've done now is to make it default
to false everywhere except for v8::ScriptOrigin constructor, which interprets an
empty Local<Boolean> as v8::True. So that would be the knob to turn if we want
to change the default.

       : flags_((is_embedder_debug_script ? kIsEmbedderDebugScript : 0) |
                (is_shared_cross_origin ? kIsSharedCrossOrigin : 0) |
-               (is_opaque ? kIsOpaque : 0)) {}
+               (is_opaque ? kIsOpaque : 0) |
+               (is_skip_html_comments ? kIsSkipHtmlComments : 0)) {}
   V8_INLINE ScriptOriginOptions(int flags)
-      : flags_(flags &
-               (kIsEmbedderDebugScript | kIsSharedCrossOrigin | kIsOpaque)) {}
-  bool IsEmbedderDebugScript() const {
-    return (flags_ & kIsEmbedderDebugScript) != 0;
-  }
-  bool IsSharedCrossOrigin() const {
-    return (flags_ & kIsSharedCrossOrigin) != 0;
-  }
-  bool IsOpaque() const { return (flags_ & kIsOpaque) != 0; }
+      : flags_(flags & (kIsEmbedderDebugScript | kIsSharedCrossOrigin |
+                        kIsOpaque | kIsSkipHtmlComments)) {}
+  bool IsEmbedderDebugScript() const { return HasFlag(kIsEmbedderDebugScript); }
+  bool IsSharedCrossOrigin() const { return HasFlag(kIsSharedCrossOrigin); }
+  bool IsOpaque() const { return HasFlag(kIsOpaque); }
+  bool IsSkipHtmlComments() const { return HasFlag(kIsSkipHtmlComments); }
   int Flags() const { return flags_; }
 
  private:
   enum {
     kIsEmbedderDebugScript = 1,
     kIsSharedCrossOrigin = 1 << 1,
-    kIsOpaque = 1 << 2
+    kIsOpaque = 1 << 2,
+    kIsSkipHtmlComments = 1 << 3
   };
+
+  inline bool HasFlag(int flag) const { return (flags_ & flag) != 0; }
+
   const int flags_;
 };
 
 /**
  * The origin, within a file, of a script.
  */
 class ScriptOrigin {
  public:
   V8_INLINE ScriptOrigin(
       Local<Value> resource_name,
       Local<Integer> resource_line_offset = Local<Integer>(),
       Local<Integer> resource_column_offset = Local<Integer>(),
       Local<Boolean> resource_is_shared_cross_origin = Local<Boolean>(),
       Local<Integer> script_id = Local<Integer>(),
       Local<Boolean> resource_is_embedder_debug_script = Local<Boolean>(),
       Local<Value> source_map_url = Local<Value>(),
-      Local<Boolean> resource_is_opaque = Local<Boolean>());
+      Local<Boolean> resource_is_opaque = Local<Boolean>(),
+      Local<Boolean> skip_html_comments = Local<Boolean>());
   V8_INLINE Local<Value> ResourceName() const;
   V8_INLINE Local<Integer> ResourceLineOffset() const;
   V8_INLINE Local<Integer> ResourceColumnOffset() const;
   /**
     * Returns true for embedder's debugger scripts
     */
   V8_INLINE Local<Integer> ScriptID() const;
   V8_INLINE Local<Value> SourceMapUrl() const;
   V8_INLINE ScriptOriginOptions Options() const { return options_; }
 
@@ skipping 6752 matching lines @@
   return length_;
 }
 
 ScriptOrigin::ScriptOrigin(Local<Value> resource_name,
                            Local<Integer> resource_line_offset,
                            Local<Integer> resource_column_offset,
                            Local<Boolean> resource_is_shared_cross_origin,
                            Local<Integer> script_id,
                            Local<Boolean> resource_is_embedder_debug_script,
                            Local<Value> source_map_url,
-                           Local<Boolean> resource_is_opaque)
+                           Local<Boolean> resource_is_opaque,
+                           Local<Boolean> skip_html_comments)
     : resource_name_(resource_name),
       resource_line_offset_(resource_line_offset),
       resource_column_offset_(resource_column_offset),
       options_(!resource_is_embedder_debug_script.IsEmpty() &&
                    resource_is_embedder_debug_script->IsTrue(),
                !resource_is_shared_cross_origin.IsEmpty() &&
                    resource_is_shared_cross_origin->IsTrue(),
-               !resource_is_opaque.IsEmpty() && resource_is_opaque->IsTrue()),
+               !resource_is_opaque.IsEmpty() && resource_is_opaque->IsTrue(),
+               skip_html_comments.IsEmpty() || skip_html_comments->IsTrue()),
       script_id_(script_id),
       source_map_url_(source_map_url) {}
 
 Local<Value> ScriptOrigin::ResourceName() const { return resource_name_; }
 
 
 Local<Integer> ScriptOrigin::ResourceLineOffset() const {
   return resource_line_offset_;
 }
 
@@ skipping 820 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // INCLUDE_V8_H_