Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 180113008: Use less conservative condition when detecting noncharacter unicode symbols (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Use less conservative condition when detecting noncharacter unicode symbols All noncharacter code points are >= 0xD800 so we can use more liberal condition when detecing characters that needs to be esscaped. BUG=347899 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 9 months ago (2014-03-05 11:33:14 UTC) #1
alph
lgtm
6 years, 9 months ago (2014-03-05 11:34:17 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-05 11:43:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/180113008/1
6 years, 9 months ago (2014-03-05 11:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/180113008/1
6 years, 9 months ago (2014-03-05 20:58:00 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 23:39:58 UTC) #6
Message was sent while issue was closed.
Change committed as 168547

Powered by Google App Engine
This is Rietveld 408576698