Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801123004: Move attachment broker setup to browser startup. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
Reviewers:
erikchen
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-mach-ports
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move attachment broker setup to browser startup. BUG=582468

Patch Set 1 #

Patch Set 2 : Fix build. #

Total comments: 1

Patch Set 3 : Maybe fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -52 lines) Patch
M content/browser/browser_child_process_host_impl.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 5 chunks +10 lines, -20 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 chunks +10 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1712143002 Patch 360001

Messages

Total messages: 5 (1 generated)
Anand Mistry (off Chromium)
WDYT? If you lgtm this, I'll probably have to fold it into https://codereview.chromium.org/1712143002/ before I ...
4 years, 9 months ago (2016-03-16 04:50:52 UTC) #2
erikchen
lgtm test failures are probably real, b/c they only show up on mac and windows. ...
4 years, 9 months ago (2016-03-16 17:33:11 UTC) #3
jam
what about the code in content/common/child_process_host_impl.cc?
4 years, 9 months ago (2016-03-17 15:35:19 UTC) #4
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-23 20:47:53 UTC) #5 
After talking to various people, I've decided not to do this. Now that we have
ChannelMojo and use it to run ChromeIPC over Mojo, all attachment brokers become
obsolete once we have a hard dependency on ChannelMojo. Since the goal is to
replace ChromeIPC and ChannelMojo is a step in that direction, I assume that
dependency will happen at some point. At that point, we can delete all the
attachment broker code including this.

Powered by Google App Engine
This is Rietveld 408576698