Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: tools/perf/benchmarks/blob_storage.py

Issue 1801123003: Disabling blob_storage.blob_storage for windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually we should disable this on all windows machines Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.timeline import tracing_category_filter 8 from telemetry.timeline import tracing_category_filter
9 from telemetry.web_perf import timeline_based_measurement 9 from telemetry.web_perf import timeline_based_measurement
10 10
11 import page_sets 11 import page_sets
12 12
13 13
14 BLOB_CATEGORY = 'Blob' 14 BLOB_CATEGORY = 'Blob'
15 TIMELINE_REQUIRED_CATEGORY = 'blink.console' 15 TIMELINE_REQUIRED_CATEGORY = 'blink.console'
16 16
17 17
18 @benchmark.Disabled('android') # http://crbug.com/499325 18 # http://crbug.com/499325
19 # http://crbug.com/595069
20 @benchmark.Disabled('android', 'win')
19 class BlobStorage(perf_benchmark.PerfBenchmark): 21 class BlobStorage(perf_benchmark.PerfBenchmark):
20 """Timeline based measurement benchmark for Blob Storage.""" 22 """Timeline based measurement benchmark for Blob Storage."""
21 23
22 page_set = page_sets.BlobWorkshopPageSet 24 page_set = page_sets.BlobWorkshopPageSet
23 25
24 def CreateTimelineBasedMeasurementOptions(self): 26 def CreateTimelineBasedMeasurementOptions(self):
25 cat_filter = tracing_category_filter.CreateMinimalOverheadFilter() 27 cat_filter = tracing_category_filter.CreateMinimalOverheadFilter()
26 cat_filter.AddIncludedCategory(BLOB_CATEGORY) 28 cat_filter.AddIncludedCategory(BLOB_CATEGORY)
27 cat_filter.AddIncludedCategory(TIMELINE_REQUIRED_CATEGORY) 29 cat_filter.AddIncludedCategory(TIMELINE_REQUIRED_CATEGORY)
28 30
29 return timeline_based_measurement.Options( 31 return timeline_based_measurement.Options(
30 overhead_level=cat_filter) 32 overhead_level=cat_filter)
31 33
32 # Necessary until crbug.com/544306 is finished. 34 # Necessary until crbug.com/544306 is finished.
33 def SetExtraBrowserOptions(self, options): 35 def SetExtraBrowserOptions(self, options):
34 options.AppendExtraBrowserArgs( 36 options.AppendExtraBrowserArgs(
35 ['--enable-experimental-web-platform-features']) 37 ['--enable-experimental-web-platform-features'])
36 38
37 @classmethod 39 @classmethod
38 def Name(cls): 40 def Name(cls):
39 return 'blob_storage.blob_storage' 41 return 'blob_storage.blob_storage'
40 42
41 @classmethod 43 @classmethod
42 def ValueCanBeAddedPredicate(cls, value, is_first_result): 44 def ValueCanBeAddedPredicate(cls, value, is_first_result):
43 if ('blob-writes' not in value.name and 45 if ('blob-writes' not in value.name and
44 'blob-reads' not in value.name): 46 'blob-reads' not in value.name):
45 return False 47 return False
46 return value.values != None 48 return value.values != None
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698