Implementation of subscription restrictions.

Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff is content/renderer/push_messaging/push_messaging_dispatcher.cc where the request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}

Committed: https://crrev.com/35c378e23dccd1bf2ad7da30bc93ffbb152859ea
Cr-Commit-Position: refs/heads/master@{#382268}

[harkness, 2016-03-15 17:45:32]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[harkness, 2016-03-15 17:45:32]

This is the re-implementation of https://codereview.chromium.org/1701313002/
which was reverted due to a crash. The crash was caused by a duplicate entry in
PushMessagingDispatcher::subscription_callbacks_ IDMap. 

The only difference between the previous code and this patch is that
PushMessagingDispatcher::DidGetManifest only adds the callback to the map if
there is an error, in which case, the error is immediately returned to the
caller.

[Peter Beverloo, 2016-03-18 12:35:48]

lgtm

[harkness, 2016-03-21 10:16:19]

Description was changed from

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

BUG=583753

Cr-Commit-Position: refs/heads/master@{#379045}
==========

to

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

[harkness, 2016-03-21 10:16:19]

harkness@chromium.org changed reviewers:
+ avi@chromium.org, mkwst@chromium.org

[harkness, 2016-03-21 10:17:38]

Description was changed from

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

to

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff
is content/renderer/push_messaging/push_messaging_dispatcher.cc where the
request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

[harkness, 2016-03-21 10:18:11]

TBR=avi,mkwst

[harkness, 2016-03-21 10:18:45]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-03-21 10:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801113003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801113003/1

[commit-bot: I haz the power, 2016-03-21 11:58:26]

Description was changed from

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff
is content/renderer/push_messaging/push_messaging_dispatcher.cc where the
request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

to

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff
is content/renderer/push_messaging/push_messaging_dispatcher.cc where the
request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

[commit-bot: I haz the power, 2016-03-21 11:58:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-21 11:59:39]

Description was changed from

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff
is content/renderer/push_messaging/push_messaging_dispatcher.cc where the
request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}
==========

to

==========
Implementation of subscription restrictions.

Currently, chrome requires that app developers provide a "sender_id" tag in the
manifest. This id is generated by the developer console and is not standard
for all browsers.

In the future, the app developer will be able to specify a public key for their
service, which will be registered with the push service and which the push
service can use to validate app services requesting to send messages.

This is a reland of CL https://codereview.chromium.org/1701313002. The only diff
is content/renderer/push_messaging/push_messaging_dispatcher.cc where the
request_id is set inside the return.

BUG=583753
TBR=avi,mkwst

Cr-Commit-Position: refs/heads/master@{#379045}

Committed: https://crrev.com/35c378e23dccd1bf2ad7da30bc93ffbb152859ea
Cr-Commit-Position: refs/heads/master@{#382268}
==========

[commit-bot: I haz the power, 2016-03-21 11:59:41]

Patchset 1 (id:??) landed as
https://crrev.com/35c378e23dccd1bf2ad7da30bc93ffbb152859ea
Cr-Commit-Position: refs/heads/master@{#382268}

[Avi (use Gerrit), 2016-03-21 15:33:04]

s lgtm