Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1801093002: Remove deprecated functions from comment for IPC::TestSink. (Closed)

Created:
4 years, 9 months ago by kotenkov
Modified:
4 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated functions from comment for IPC::TestSink. Use RunLoop instead of MessageLoop. BUG=none Committed: https://crrev.com/b2bb5e983be4b2a14231be27caa9108d518726dd Cr-Commit-Position: refs/heads/master@{#381531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ipc/ipc_test_sink.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kotenkov
I've stumbled upon an outdated comment and fixed it. PTAL
4 years, 9 months ago (2016-03-15 15:15:42 UTC) #2
kotenkov
Changed jeremy@ -> cpu@. PTAL
4 years, 9 months ago (2016-03-15 15:26:00 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
4 years, 9 months ago (2016-03-16 19:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801093002/1
4 years, 9 months ago (2016-03-16 19:40:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:50:15 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:53:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2bb5e983be4b2a14231be27caa9108d518726dd
Cr-Commit-Position: refs/heads/master@{#381531}

Powered by Google App Engine
This is Rietveld 408576698