Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1801043002: [iOS] //rlz:rlz_id should not be build on iOS. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@crypto
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] //rlz:rlz_id should not be build on iOS. There is no point building this on iOS (if it needs to be build, it probably should be build on the "host" not the "target"). BUG=459705 Committed: https://crrev.com/763bbe944c22635b01caaa86cceb65a21fa1bb4c Cr-Commit-Position: refs/heads/master@{#381928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M rlz/BUILD.gn View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-15 13:57:44 UTC) #2
sdefresne
dpranke: Please take a look.
4 years, 9 months ago (2016-03-17 12:44:19 UTC) #4
Dirk Pranke
whoops, thought I had already reviewed this. lgtm.
4 years, 9 months ago (2016-03-17 17:24:23 UTC) #5
sdefresne
On 2016/03/17 at 17:24:23, dpranke wrote: > whoops, thought I had already reviewed this. > ...
4 years, 9 months ago (2016-03-17 17:39:42 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
4 years, 9 months ago (2016-03-18 04:30:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801043002/1
4 years, 9 months ago (2016-03-18 09:50:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 10:30:17 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 10:31:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763bbe944c22635b01caaa86cceb65a21fa1bb4c
Cr-Commit-Position: refs/heads/master@{#381928}

Powered by Google App Engine
This is Rietveld 408576698