Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1801033003: [Android] Pass original unicode character to blink for dead keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite unittest and avoid creating KeyEvent Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index 5ca8978e88823e8bfb907e07684f43c9ee1486df..d3ece9cf66144a93f5db4c0922a1c24384bfe8f3 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -506,7 +506,8 @@ public class ImeAdapter {
flags));
}
- boolean sendCompositionToNative(CharSequence text, int newCursorPosition, boolean isCommit) {
+ boolean sendCompositionToNative(
+ CharSequence text, int newCursorPosition, boolean isCommit, int unicodeFromKeyEvent) {
if (mNativeImeAdapterAndroid == 0) return false;
// One WebView app detects Enter in JS by looking at KeyDown (http://crbug/577967).
@@ -519,7 +520,7 @@ public class ImeAdapter {
mViewEmbedder.onImeEvent();
long timestampMs = SystemClock.uptimeMillis();
nativeSendSyntheticKeyEvent(mNativeImeAdapterAndroid, WebInputEventType.RawKeyDown,
- timestampMs, COMPOSITION_KEY_CODE, 0, 0);
+ timestampMs, COMPOSITION_KEY_CODE, 0, unicodeFromKeyEvent);
if (isCommit) {
nativeCommitText(mNativeImeAdapterAndroid, text.toString());
@@ -528,8 +529,8 @@ public class ImeAdapter {
mNativeImeAdapterAndroid, text, text.toString(), newCursorPosition);
}
- nativeSendSyntheticKeyEvent(mNativeImeAdapterAndroid, WebInputEventType.KeyUp,
- timestampMs, COMPOSITION_KEY_CODE, 0, 0);
+ nativeSendSyntheticKeyEvent(mNativeImeAdapterAndroid, WebInputEventType.KeyUp, timestampMs,
+ COMPOSITION_KEY_CODE, 0, unicodeFromKeyEvent);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698