[Interpreter]: Move builtin-id from function_data to function_identifier.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 
 #include <algorithm>
 
 #include "src/ast/ast-numbering.h"
 #include "src/ast/prettyprinter.h"
@@ skipping 768 matching lines @@
   if (!Compiler::Analyze(info->parse_info()) ||
       !FullCodeGenerator::MakeCode(info)) {
     Isolate* isolate = info->isolate();
     if (!isolate->has_pending_exception()) isolate->StackOverflow();
     return false;
   }
   return true;
 }
 
 
 static bool UseIgnition(CompilationInfo* info) {

[Michael Starzinger, 2016/03/15 14:19:13]

As discussed offline: We now need to guard and blacklist the three generator
builtins (i.e. kGeneratorObjectNext, kGeneratorObjectReturn and
kGeneratorObjectThrow) here.

[rmcilroy, 2016/03/15 17:31:46]

Yup, missed this. Done.

-  // Cannot use Ignition when the {function_data} is already used.
-  if (info->has_shared_info() && info->shared_info()->HasBuiltinFunctionId()) {
-    return false;
-  }
-
   // TODO(4681): Generators are not yet supported.
   if ((info->has_shared_info() && info->shared_info()->is_generator()) ||
       (info->has_literal() && IsGeneratorFunction(info->literal()->kind()))) {
     return false;
   }
 
   // Checks whether top level functions should be passed by the filter.
   if (info->closure().is_null()) {
     Vector<const char> filter = CStrVector(FLAG_ignition_filter);
     return (filter.length() == 0) || (filter.length() == 1 && filter[0] == '*');
@@ skipping 1161 matching lines @@
 
 #if DEBUG
 void CompilationInfo::PrintAstForTesting() {
   PrintF("--- Source from AST ---\n%s\n",
          PrettyPrinter(isolate()).PrintProgram(literal()));
 }
 #endif
 
 }  // namespace internal
 }  // namespace v8