Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1801013002: [wasm] Int64Lowering of F64ReinterpretI64. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@wasm-bit-cast
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Int64Lowering of F64ReinterpretI64. The implementation is done by storing to and then loading from memory. R=titzer@chromium.org Committed: https://crrev.com/ccbf004293f19dd76f0abf68add8fe01434d9ef9 Cr-Commit-Position: refs/heads/master@{#34785}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M src/compiler/int64-lowering.cc View 1 3 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 9 months ago (2016-03-15 09:24:37 UTC) #1
titzer
On 2016/03/15 09:24:37, ahaas wrote: lgtm
4 years, 9 months ago (2016-03-15 09:29:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801013002/20001
4 years, 9 months ago (2016-03-15 12:28:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 12:45:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 12:46:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ccbf004293f19dd76f0abf68add8fe01434d9ef9
Cr-Commit-Position: refs/heads/master@{#34785}

Powered by Google App Engine
This is Rietveld 408576698