Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1800973002: MD text buttons - implement focus ring. (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD text buttons - implement focus ring. BUG=571500, 593614 Committed: https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46 Cr-Commit-Position: refs/heads/master@{#381377}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -5 lines) Patch
M ui/gfx/geometry/insets.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/geometry/insets_f.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/geometry/insets_f.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.h View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 4 chunks +57 lines, -3 lines 2 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
4 years, 9 months ago (2016-03-15 01:47:02 UTC) #2
sky
https://codereview.chromium.org/1800973002/diff/1/ui/views/controls/button/md_text_button.cc File ui/views/controls/button/md_text_button.cc (right): https://codereview.chromium.org/1800973002/diff/1/ui/views/controls/button/md_text_button.cc#newcode33 ui/views/controls/button/md_text_button.cc:33: class MdFocusRing : public views::View { Seems rather heavy ...
4 years, 9 months ago (2016-03-15 16:49:26 UTC) #3
Evan Stade
https://codereview.chromium.org/1800973002/diff/1/ui/views/controls/button/md_text_button.cc File ui/views/controls/button/md_text_button.cc (right): https://codereview.chromium.org/1800973002/diff/1/ui/views/controls/button/md_text_button.cc#newcode33 ui/views/controls/button/md_text_button.cc:33: class MdFocusRing : public views::View { On 2016/03/15 16:49:26, ...
4 years, 9 months ago (2016-03-15 19:09:43 UTC) #4
sky
Go with this. We can optimize if that proves necessary. LGTM
4 years, 9 months ago (2016-03-15 20:40:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800973002/1
4 years, 9 months ago (2016-03-15 21:09:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/195702)
4 years, 9 months ago (2016-03-15 22:54:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800973002/1
4 years, 9 months ago (2016-03-16 00:45:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 01:07:28 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 01:09:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46
Cr-Commit-Position: refs/heads/master@{#381377}

Powered by Google App Engine
This is Rietveld 408576698