Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1800963002: [remoting android] Set contentInsetStart on each Toolbar. (Closed)

Created:
4 years, 9 months ago by Lambros
Modified:
4 years, 9 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Set contentInsetStart on each Toolbar. This sets contentInsetStart to 72dp on phones and 80dp on tablets. BUG=593844 Committed: https://crrev.com/970a34f528351cbc0f9f12260b574d11f5bf6f27 Cr-Commit-Position: refs/heads/master@{#381324}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M remoting/android/java/res/layout/credits.xml View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/android/java/res/layout/desktop.xml View 1 chunk +1 line, -1 line 2 comments Download
M remoting/android/java/res/layout/help.xml View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/android/java/res/layout/main.xml View 1 chunk +1 line, -2 lines 0 comments Download
A + remoting/android/java/res/values-sw600dp/dimens.xml View 1 chunk +2 lines, -6 lines 0 comments Download
M remoting/android/java/res/values-v17/styles.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/android/java/res/values/dimens.xml View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lambros
I figured out the implementation for myself, but it turns out to be identical to ...
4 years, 9 months ago (2016-03-15 01:40:25 UTC) #2
joedow
lgtm https://codereview.chromium.org/1800963002/diff/1/remoting/android/java/res/layout/desktop.xml File remoting/android/java/res/layout/desktop.xml (right): https://codereview.chromium.org/1800963002/diff/1/remoting/android/java/res/layout/desktop.xml#newcode25 remoting/android/java/res/layout/desktop.xml:25: style="@style/ToolbarStyle"/> This change will add elevation to this ...
4 years, 9 months ago (2016-03-15 20:42:53 UTC) #3
Lambros
https://codereview.chromium.org/1800963002/diff/1/remoting/android/java/res/layout/desktop.xml File remoting/android/java/res/layout/desktop.xml (right): https://codereview.chromium.org/1800963002/diff/1/remoting/android/java/res/layout/desktop.xml#newcode25 remoting/android/java/res/layout/desktop.xml:25: style="@style/ToolbarStyle"/> On 2016/03/15 20:42:53, joedow wrote: > This change ...
4 years, 9 months ago (2016-03-15 21:07:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800963002/1
4 years, 9 months ago (2016-03-15 21:08:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 21:47:20 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 21:48:40 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/970a34f528351cbc0f9f12260b574d11f5bf6f27
Cr-Commit-Position: refs/heads/master@{#381324}

Powered by Google App Engine
This is Rietveld 408576698