ServiceWorker: Move ExtendableMessageEvent dispatching out of ServiceWorkerVersion

ServiceWorker: Move ExtendableMessageEvent dispatching out of ServiceWorkerVersion

This is a part of event dispatching cleanups in ServiceWorkerVersion (see issue
570820). Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
Committed: https://crrev.com/cd64406260a7ba2f99bb66f6be2a0a1c4f8d3c2a
Cr-Commit-Position: refs/heads/master@{#381204}

[nhiroki, 2016-03-15 04:49:27]

Description was changed from

==========
ServiceWorker: Move DispatchExtendableMessageEvent from ServiceWorkerVersion to
ServiceWorkerDispatcherHost

BUG=
==========

to

==========
ServiceWorker: Move DispatchExtendableMessageEvent from SWVersion to SWDispat…

BUG=
==========

[nhiroki, 2016-03-15 04:50:10]

Description was changed from

==========
ServiceWorker: Move DispatchExtendableMessageEvent from SWVersion to SWDispat…

BUG=
==========

to

==========
ServiceWorker: Move DispatchExtendableMessageEvent to ServiceWorkerDispatcher

BUG=
==========

[nhiroki, 2016-03-15 04:50:25]

Description was changed from

==========
ServiceWorker: Move DispatchExtendableMessageEvent to ServiceWorkerDispatcher

BUG=
==========

to

==========
ServiceWorker: Move DispatchExtendableMessageEvent to
ServiceWorkerDispatcherHost

BUG=
==========

[nhiroki, 2016-03-15 04:51:24]

Description was changed from

==========
ServiceWorker: Move DispatchExtendableMessageEvent to
ServiceWorkerDispatcherHost

BUG=
==========

to

==========
ServiceWorker: Move DispatchExtendableMessageEvent to
ServiceWorkerDispatcherHost

BUG=543198, 570820
==========

[nhiroki, 2016-03-15 04:59:50]

Description was changed from

==========
ServiceWorker: Move DispatchExtendableMessageEvent to
ServiceWorkerDispatcherHost

BUG=543198, 570820
==========

to

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

BUG=543198, 570820
==========

[nhiroki, 2016-03-15 05:05:46]

Description was changed from

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

BUG=543198, 570820
==========

to

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a series of refactoring for ServiceWorkerVersion (see issue 570820).
Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

[nhiroki, 2016-03-15 05:07:42]

Description was changed from

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a series of refactoring for ServiceWorkerVersion (see issue 570820).
Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

to

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a part of refactoring for ServiceWorkerVersion (see issue 570820).
Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

[nhiroki, 2016-03-15 05:07:52]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-03-15 06:09:51]

Description was changed from

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a part of refactoring for ServiceWorkerVersion (see issue 570820).
Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

to

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a part of event dispatching cleanups in ServiceWorkerVersion (see issue
570820). Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

[nhiroki, 2016-03-15 06:17:24]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2016-03-15 06:17:25]

Hi falken@, can you review this?

This cleanup is helpful for making a patch to handle failures of
ExtendableMessageEvent dispatching [1].

[1] https://codereview.chromium.org/1799413002/

Thanks!

[falken, 2016-03-15 07:29:17]

lgtm

https://codereview.chromium.org/1800953003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/1800953003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.cc:735: this,
sent_message_ports, SERVICE_WORKER_ERROR_FAILED));
Should we bother handling this after NOTREACHED? Probably not according to the
style guide.

[nhiroki, 2016-03-15 07:41:00]

Patchset #2 (id:40001) has been deleted

[nhiroki, 2016-03-15 07:57:26]

Thank you!

https://codereview.chromium.org/1800953003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/1800953003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_dispatcher_host.cc:735: this,
sent_message_ports, SERVICE_WORKER_ERROR_FAILED));
On 2016/03/15 07:29:16, falken wrote:
> Should we bother handling this after NOTREACHED? Probably not according to the
> style guide.

Good point. Yes, we don't have to handle the case. Removed.

[nhiroki, 2016-03-15 07:57:35]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-03-15 07:57:35]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1800953003/#ps60001
(title: "remove unnecessary code")

[commit-bot: I haz the power, 2016-03-15 07:57:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1800953003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1800953003/60001

[commit-bot: I haz the power, 2016-03-15 09:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 09:01:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2016-03-15 09:11:30]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-03-15 09:11:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1800953003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1800953003/60001

[commit-bot: I haz the power, 2016-03-15 10:35:50]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-03-15 10:36:48]

Description was changed from

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a part of event dispatching cleanups in ServiceWorkerVersion (see issue
570820). Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820
==========

to

==========
ServiceWorker: Move ExtendableMessageEvent dispatching out of
ServiceWorkerVersion

This is a part of event dispatching cleanups in ServiceWorkerVersion (see issue
570820). Diffs are basically just moved from ServiceWorkerVersion to
ServiceWorkerDispatcherHost.

BUG=543198, 570820

Committed: https://crrev.com/cd64406260a7ba2f99bb66f6be2a0a1c4f8d3c2a
Cr-Commit-Position: refs/heads/master@{#381204}
==========

[commit-bot: I haz the power, 2016-03-15 10:36:49]

Patchset 2 (id:??) landed as
https://crrev.com/cd64406260a7ba2f99bb66f6be2a0a1c4f8d3c2a
Cr-Commit-Position: refs/heads/master@{#381204}