Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1800953002: Add MojoVideoDecoder. (Closed)

Created:
4 years, 9 months ago by sandersd (OOO until July 31)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MojoVideoDecoder. This skeleton adds support for a MojoVideoDecoder, but does not implement a decoder service. To enable, use these gn args: enable_mojo_media = true mojo_media_services = [ "video_decoder" ] BUG=522298 Committed: https://crrev.com/02864e3315b0959644d47603a2d2627474deb9fb Cr-Commit-Position: refs/heads/master@{#381331}

Patch Set 1 #

Patch Set 2 : Cleanups. #

Total comments: 7

Patch Set 3 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -43 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/media_options.gni View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_decoder_factory.h View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.cc View 1 chunk +14 lines, -4 lines 0 comments Download
A + media/mojo/services/mojo_video_decoder.h View 1 2 3 chunks +14 lines, -11 lines 0 comments Download
A + media/mojo/services/mojo_video_decoder.cc View 4 chunks +22 lines, -9 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sandersd (OOO until July 31)
4 years, 9 months ago (2016-03-15 01:27:10 UTC) #2
xhwang
LGTM Thanks for the fix! https://chromiumcodereview.appspot.com/1800953002/diff/20001/media/media_options.gni File media/media_options.gni (right): https://chromiumcodereview.appspot.com/1800953002/diff/20001/media/media_options.gni#newcode89 media/media_options.gni:89: # - "cdm": Use ...
4 years, 9 months ago (2016-03-15 05:13:18 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/1800953002/diff/20001/media/media_options.gni File media/media_options.gni (right): https://codereview.chromium.org/1800953002/diff/20001/media/media_options.gni#newcode89 media/media_options.gni:89: # - "cdm": Use mojo based Content Decryption Module. ...
4 years, 9 months ago (2016-03-15 18:31:02 UTC) #4
sandersd (OOO until July 31)
jochen@chromium.org: Please review changes in RenderFrameImpl.
4 years, 9 months ago (2016-03-15 18:31:28 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-15 20:27:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800953002/40001
4 years, 9 months ago (2016-03-15 20:28:11 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 22:02:22 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 22:04:01 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02864e3315b0959644d47603a2d2627474deb9fb
Cr-Commit-Position: refs/heads/master@{#381331}

Powered by Google App Engine
This is Rietveld 408576698