Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1800883002: Revert "Add histograms to track down the cause of ERR_SSL_PROTOCOL_ERROR." (Closed)

Created:
4 years, 9 months ago by davidben
Modified:
4 years, 9 months ago
Reviewers:
Ilya Sherman, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add histograms to track down the cause of ERR_SSL_PROTOCOL_ERROR." This reverts commit 6e50b9f54970b1527162fba5611b8d1b41a9d9ba. The cause of the bug is known, so the metrics are no longer needed. BUG=593963 Committed: https://crrev.com/cfd0f177624b11ad7c22aa931eb1771728e6fa0d Cr-Commit-Position: refs/heads/master@{#382091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M net/socket/ssl_client_socket_openssl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 4 chunks +0 lines, -32 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
davidben
I'll probably wait a couple days to land this just to make sure the fix ...
4 years, 9 months ago (2016-03-14 23:17:00 UTC) #2
mattm
lgtm
4 years, 9 months ago (2016-03-14 23:20:17 UTC) #3
Ilya Sherman
lgtm, thanks
4 years, 9 months ago (2016-03-14 23:29:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800883002/1
4 years, 9 months ago (2016-03-18 17:30:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/198766)
4 years, 9 months ago (2016-03-18 19:05:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800883002/1
4 years, 9 months ago (2016-03-18 19:42:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 21:21:39 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:23:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfd0f177624b11ad7c22aa931eb1771728e6fa0d
Cr-Commit-Position: refs/heads/master@{#382091}

Powered by Google App Engine
This is Rietveld 408576698