Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: runtime/bin/log_android.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Windows fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_ANDROID) 6 #if defined(TARGET_OS_ANDROID)
7 7
8 #include "bin/log.h" 8 #include "bin/log.h"
9 9
10 #include <android/log.h> // NOLINT
10 #include <stdio.h> // NOLINT 11 #include <stdio.h> // NOLINT
11 #include <android/log.h> // NOLINT
12
13 12
14 namespace dart { 13 namespace dart {
15 namespace bin { 14 namespace bin {
16 15
17 // TODO(gram): We should be buffering the data and only outputting 16 // TODO(gram): We should be buffering the data and only outputting
18 // it when we see a '\n'. 17 // it when we see a '\n'.
19 18
20 void Log::VPrint(const char* format, va_list args) { 19 void Log::VPrint(const char* format, va_list args) {
21 __android_log_vprint(ANDROID_LOG_INFO, "Dart", format, args); 20 __android_log_vprint(ANDROID_LOG_INFO, "Dart", format, args);
22 } 21 }
23 22
24 void Log::VPrintErr(const char* format, va_list args) { 23 void Log::VPrintErr(const char* format, va_list args) {
25 __android_log_vprint(ANDROID_LOG_ERROR, "Dart", format, args); 24 __android_log_vprint(ANDROID_LOG_ERROR, "Dart", format, args);
26 } 25 }
27 26
28 } // namespace bin 27 } // namespace bin
29 } // namespace dart 28 } // namespace dart
30 29
31 #endif // defined(TARGET_OS_ANDROID) 30 #endif // defined(TARGET_OS_ANDROID)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698