Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: runtime/bin/io_buffer.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Windows fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/io_buffer.h" 5 #include "bin/io_buffer.h"
6 6
7
8 namespace dart { 7 namespace dart {
9 namespace bin { 8 namespace bin {
10 9
11 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { 10 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
12 uint8_t* data = Allocate(size); 11 uint8_t* data = Allocate(size);
13 Dart_Handle result = Dart_NewExternalTypedData( 12 Dart_Handle result = Dart_NewExternalTypedData(
14 Dart_TypedData_kUint8, data, size); 13 Dart_TypedData_kUint8, data, size);
15 Dart_NewWeakPersistentHandle(result, data, size, IOBuffer::Finalizer); 14 Dart_NewWeakPersistentHandle(result, data, size, IOBuffer::Finalizer);
16 15
17 if (Dart_IsError(result)) { 16 if (Dart_IsError(result)) {
18 Free(data); 17 Free(data);
19 Dart_PropagateError(result); 18 Dart_PropagateError(result);
20 } 19 }
21 if (buffer != NULL) { 20 if (buffer != NULL) {
22 *buffer = data; 21 *buffer = data;
23 } 22 }
24 return result; 23 return result;
25 } 24 }
26 25
27 26
28 uint8_t* IOBuffer::Allocate(intptr_t size) { 27 uint8_t* IOBuffer::Allocate(intptr_t size) {
29 return new uint8_t[size]; 28 return new uint8_t[size];
30 } 29 }
31 30
32 } // namespace bin 31 } // namespace bin
33 } // namespace dart 32 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698