Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1800843003: Mojo C++ bindings: fix the for_blink_tests target. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix the for_blink_tests target. It depends on mojo_public_test_support, which is unnecessary and broke blink_platform_unittests in isolated mode. BUG=583738 TBR=rockot@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/451ae6ebf3666d077c380d715f62dfe55f666504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M mojo/mojo_edk_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/451ae6ebf3666d077c380d715f62dfe55f666504 Cr-Commit-Position: refs/heads/master@{#381164}
4 years, 9 months ago (2016-03-15 03:08:08 UTC) #2
yzshen1
Committed patchset #1 (id:1) manually as 451ae6ebf3666d077c380d715f62dfe55f666504 (presubmit successful).
4 years, 9 months ago (2016-03-15 03:08:52 UTC) #4
Ken Rockot(use gerrit already)
lgtm -i'll look into killing mojo/public/c/test_support. it's caused trouble in the past and it's not ...
4 years, 9 months ago (2016-03-15 03:15:13 UTC) #5
yzshen1
4 years, 9 months ago (2016-03-15 03:17:53 UTC) #6
Message was sent while issue was closed.
On 2016/03/15 03:15:13, Ken Rockot wrote:
> lgtm -i'll look into killing mojo/public/c/test_support. it's caused trouble
in
> the past and it's not really needed anymore

+1!

Powered by Google App Engine
This is Rietveld 408576698