Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1800843002: save-data header value gets appended on page refreshes (Closed)

Created:
4 years, 9 months ago by tbansal1
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, Yoav Weiss, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

save-data header value gets appended on page refreshes When data-saver is enabled, Chrome sets save-data header value to 'on'. When the webpage is refreshed, the sub resource requests get the save-data value as 'on,on'. BUG=591594 Review URL: https://codereview.chromium.org/1783653002 Cr-Commit-Position: refs/heads/master@{#380568} (cherry picked from commit 8c957da3f5a7b7e3eb37483a57ebbf323f997f1f) Committed: https://chromium.googlesource.com/chromium/src/+/a773f1e10667737074f79c4caa9de50da1fbd073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M chrome/browser/data_saver/data_saver_browsertest.cc View 3 chunks +59 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 9 months ago (2016-03-14 21:55:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a773f1e10667737074f79c4caa9de50da1fbd073 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698