Issue 180083002: defer to skia_for_chromium_defines.gypi for temporary guard defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180083002: defer to skia_for_chromium_defines.gypi for temporary guard defines (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 9 months ago

Reviewers:
bungeman-chromium, robertphillips

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

defer to skia_for_chromium_defines.gypi for temporary guard defines needs https://codereview.chromium.org/180063003/ to have landed first R=bungeman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253810

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	skia/skia_common.gypi	View	1 2	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-chromium

lgtm with nit https://codereview.chromium.org/180083002/diff/1/skia/skia_common.gypi File skia/skia_common.gypi (right): https://codereview.chromium.org/180083002/diff/1/skia/skia_common.gypi#newcode179 skia/skia_common.gypi:179: nit: don't need this whitespace change.

6 years, 10 months ago (2014-02-25 18:06:51 UTC) #2

reed1

6 years, 9 months ago (2014-02-27 14:30:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r253810 (presubmit successful).

Expand Messages | Collapse Messages

Issue 180083002: defer to skia_for_chromium_defines.gypi for temporary guard defines (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Messages