Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 180083002: defer to skia_for_chromium_defines.gypi for temporary guard defines (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

defer to skia_for_chromium_defines.gypi for temporary guard defines needs https://codereview.chromium.org/180063003/ to have landed first R=bungeman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253810

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M skia/skia_common.gypi View 1 2 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
6 years, 10 months ago (2014-02-25 17:02:16 UTC) #1
bungeman-chromium
lgtm with nit https://codereview.chromium.org/180083002/diff/1/skia/skia_common.gypi File skia/skia_common.gypi (right): https://codereview.chromium.org/180083002/diff/1/skia/skia_common.gypi#newcode179 skia/skia_common.gypi:179: nit: don't need this whitespace change.
6 years, 10 months ago (2014-02-25 18:06:51 UTC) #2
reed1
6 years, 9 months ago (2014-02-27 14:30:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r253810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698