Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1800793003: Check if the resizer has been deleted during drag start. (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if the resizer has been deleted during drag start. BUG=579226 TEST=ToplevelWindowEventHandler.CancelWhileDragStart Committed: https://crrev.com/3d990e41305fb59c8660461fde7a2d459095e60f Cr-Commit-Position: refs/heads/master@{#381243}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M ash/wm/dock/docked_window_resizer.h View 1 chunk +3 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 4 chunks +12 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 3 chunks +33 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800793003/1
4 years, 9 months ago (2016-03-15 07:40:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 08:15:45 UTC) #4
oshima
4 years, 9 months ago (2016-03-15 09:09:33 UTC) #6
oshima
https://codereview.chromium.org/1800793003/diff/1/ash/wm/toplevel_window_event_handler_unittest.cc File ash/wm/toplevel_window_event_handler_unittest.cc (right): https://codereview.chromium.org/1800793003/diff/1/ash/wm/toplevel_window_event_handler_unittest.cc#newcode72 ash/wm/toplevel_window_event_handler_unittest.cc:72: kShellWindowId_DefaultContainer); This is is to use normal dragging path ...
4 years, 9 months ago (2016-03-15 09:15:04 UTC) #7
varkha
LGTM. That second bug with the dual screen scenario really helped.
4 years, 9 months ago (2016-03-15 15:26:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800793003/1
4 years, 9 months ago (2016-03-15 17:31:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 17:37:52 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 17:39:29 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d990e41305fb59c8660461fde7a2d459095e60f
Cr-Commit-Position: refs/heads/master@{#381243}

Powered by Google App Engine
This is Rietveld 408576698