Chromium Code Reviews| Index: fpdfsdk/fsdk_baseform.cpp |
| diff --git a/fpdfsdk/fsdk_baseform.cpp b/fpdfsdk/fsdk_baseform.cpp |
| index 141e1f5f82644eb7e9326861375e6d9adb0dceeb..78e3d515f3d99f43ee90d44cc67407fe950555f9 100644 |
| --- a/fpdfsdk/fsdk_baseform.cpp |
| +++ b/fpdfsdk/fsdk_baseform.cpp |
| @@ -350,19 +350,19 @@ void CPDFSDK_Widget::SynchronizeXFAValue(IXFA_DocView* pXFADocView, |
| case FIELDTYPE_CHECKBOX: { |
| if (CXFA_WidgetAcc* pWidgetAcc = |
| pXFAWidgetHandler->GetDataAcc(hWidget)) { |
| - FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; |
| - |
| + bool bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; |
|
Tom Sepez
2016/03/15 15:28:47
nit: local not needed.
Wei Li
2016/03/15 17:58:14
Done.
|
| pFormField->CheckControl(pFormField->GetControlIndex(pFormControl), |
| - bChecked, TRUE); |
| + bChecked, true); |
| } |
| } break; |
| case FIELDTYPE_RADIOBUTTON: { |
| + // TODO(weili): Check whether we need to handle checkbox and radio |
| + // button differently, otherwise, merge these two cases. |
| if (CXFA_WidgetAcc* pWidgetAcc = |
| pXFAWidgetHandler->GetDataAcc(hWidget)) { |
| - FX_BOOL bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; |
| - |
| + bool bChecked = pWidgetAcc->GetCheckState() == XFA_CHECKSTATE_On; |
| pFormField->CheckControl(pFormField->GetControlIndex(pFormControl), |
| - bChecked, TRUE); |
| + bChecked, true); |
| } |
| } break; |
| case FIELDTYPE_TEXTFIELD: { |