Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4285)

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 1800773002: Output the version of MSVS in chrome://version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/version_ui.cc
diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc
index f9c70a1e20ca55507f8a401b2a9ddd9f10498f24..45ac460b45c46bbf32bac36f7333914a4e324ceb 100644
--- a/chrome/browser/ui/webui/version_ui.cc
+++ b/chrome/browser/ui/webui/version_ui.cc
@@ -139,10 +139,16 @@ WebUIDataSource* CreateVersionUIDataSource() {
#if defined(OS_WIN)
#if defined(__clang__)
html_source->AddString("compiler", "clang");
+#elif defined(_MSC_VER) && _MSC_VER == 1900
+ html_source->AddString("compiler", "MSVC 2015");
+#elif defined(_MSC_VER) && _MSC_VER == 1800
+ html_source->AddString("compiler", "MSVC 2013");
+#elif defined(_MSC_VER)
+#error "Unsupported version of MSVC."
#else
- html_source->AddString("compiler", "MSVC");
-#endif
+ html_source->AddString("compiler", "Unknown");
#endif
+#endif // defined(OS_WIN)
html_source->SetJsonPath("strings.js");
html_source->AddResourcePath(version_ui::kVersionJS, IDR_VERSION_UI_JS);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698