Output the version of MSVS in chrome://version

chrome/browser/ui/webui/version_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/version_ui.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 122 matching lines @@
                                   IDS_VERSION_UI_PROFILE_PATH);
   html_source->AddString(version_ui::kProfilePath, std::string());
 
   html_source->AddLocalizedString(version_ui::kVariationsName,
                                   IDS_VERSION_UI_VARIATIONS);
 
 #if defined(OS_WIN)
 #if defined(__clang__)
   html_source->AddString("compiler", "clang");
 #else
-  html_source->AddString("compiler", "MSVC");
+#if _MSC_VER == 1900

[Dan Beam, 2016/03/15 00:45:12]

can this #else + #if be #elif and one less #endif?

[Will Harris, 2016/03/15 01:23:30]

Done.

+  html_source->AddString("compiler", "MSVC 2015");
+#elif _MSC_VER == 1800
+  html_source->AddString("compiler", "MSVC 2013");
+#else
+#error "Unsupported version of MSVS compiler."
+#endif
 #endif
 #endif

[Dan Beam, 2016/03/15 00:45:12]

please add #endif  // defined(OS_WIN) to final #endif

[Dan Beam, 2016/03/15 00:45:12]

nit: is it possible to use mingw/g++ on windows?

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/vagGh...
seems to imply "no"

if so:

#if defined(OS_WIN)
#if defined(__clang__)
  html_source->AddString("compiler", "clang");
#elif defined(_MSC_VER) && _MSC_VER == 1800
  html_source->AddString("compiler", "MSVC 2013");
#elif defined(_MSC_VER) && _MSC_VER == 1900
  html_source->AddString("compiler", "MSVC 2015");
#else
  html_source->AddString("compiler", "Unknown");
#endif
#endif  // defined(OS_WIN)

otherwise, lgtm

[Will Harris, 2016/03/15 01:23:30]

Done.

[Will Harris, 2016/03/15 01:23:30]

pretty sure you can't use g++ except maybe for base?

certainly not chrome code...

I'd like to still support Bruce's idea of erroring if we forget to update this
when we move to VS2018 so I'll leave the #error if it's MSVS but also support
the "Unknown" compiler if nothing else matches.

 
   html_source->SetJsonPath("strings.js");
   html_source->AddResourcePath(version_ui::kVersionJS, IDR_VERSION_UI_JS);
   html_source->AddResourcePath(version_ui::kAboutVersionCSS,
                                IDR_VERSION_UI_CSS);
   html_source->SetDefaultResource(IDR_VERSION_UI_HTML);
   return html_source;
 }
 
 }  // namespace
@@ skipping 12 matching lines @@
   // Set up the chrome://theme/ source.
   ThemeSource* theme = new ThemeSource(profile);
   content::URLDataSource::Add(profile, theme);
 #endif
 
   WebUIDataSource::Add(profile, CreateVersionUIDataSource());
 }
 
 VersionUI::~VersionUI() {
 }