Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 1800743003: base: Remove some unnecessary const scoped_refptr<>&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.h
diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h
index e9b09f8f0c3b9e3f88b53d569684c5b7f4133a17..79686c8fb053e539559633eedde08cda2cf85477 100644
--- a/base/trace_event/memory_dump_manager.h
+++ b/base/trace_event/memory_dump_manager.h
@@ -73,19 +73,17 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
// the calls to |mdp| will be run on the given |task_runner|. If passed
// null |mdp| should be able to handle calls on arbitrary threads.
// - options: extra optional arguments. See memory_dump_provider.h.
- void RegisterDumpProvider(
- MemoryDumpProvider* mdp,
- const char* name,
- const scoped_refptr<SingleThreadTaskRunner>& task_runner);
- void RegisterDumpProvider(
- MemoryDumpProvider* mdp,
- const char* name,
- const scoped_refptr<SingleThreadTaskRunner>& task_runner,
- MemoryDumpProvider::Options options);
+ void RegisterDumpProvider(MemoryDumpProvider* mdp,
+ const char* name,
+ scoped_refptr<SingleThreadTaskRunner> task_runner);
+ void RegisterDumpProvider(MemoryDumpProvider* mdp,
+ const char* name,
+ scoped_refptr<SingleThreadTaskRunner> task_runner,
+ MemoryDumpProvider::Options options);
void RegisterDumpProviderWithSequencedTaskRunner(
MemoryDumpProvider* mdp,
const char* name,
- const scoped_refptr<SequencedTaskRunner>& task_runner,
+ scoped_refptr<SequencedTaskRunner> task_runner,
MemoryDumpProvider::Options options);
void UnregisterDumpProvider(MemoryDumpProvider* mdp);
@@ -174,11 +172,10 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
using OrderedSet =
std::set<scoped_refptr<MemoryDumpProviderInfo>, Comparator>;
- MemoryDumpProviderInfo(
- MemoryDumpProvider* dump_provider,
- const char* name,
- const scoped_refptr<SequencedTaskRunner>& task_runner,
- const MemoryDumpProvider::Options& options);
+ MemoryDumpProviderInfo(MemoryDumpProvider* dump_provider,
+ const char* name,
+ scoped_refptr<SequencedTaskRunner> task_runner,
+ const MemoryDumpProvider::Options& options);
MemoryDumpProvider* const dump_provider;
@@ -217,9 +214,9 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
ProcessMemoryDumpAsyncState(
MemoryDumpRequestArgs req_args,
const MemoryDumpProviderInfo::OrderedSet& dump_providers,
- const scoped_refptr<MemoryDumpSessionState>& session_state,
+ scoped_refptr<MemoryDumpSessionState> session_state,
MemoryDumpCallback callback,
- const scoped_refptr<SingleThreadTaskRunner>& dump_thread_task_runner);
+ scoped_refptr<SingleThreadTaskRunner> dump_thread_task_runner);
~ProcessMemoryDumpAsyncState();
// Gets or creates the memory dump container for the given target process.
@@ -299,7 +296,7 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {
void RegisterDumpProviderInternal(
MemoryDumpProvider* mdp,
const char* name,
- const scoped_refptr<SequencedTaskRunner>& task_runner,
+ scoped_refptr<SequencedTaskRunner> task_runner,
const MemoryDumpProvider::Options& options);
// Helper for the public UnregisterDumpProvider* functions.

Powered by Google App Engine
This is Rietveld 408576698