Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: base/threading/sequenced_worker_pool.cc

Issue 1800743003: base: Remove some unnecessary const scoped_refptr<>&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/sequenced_worker_pool.h" 5 #include "base/threading/sequenced_worker_pool.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 }; 91 };
92 92
93 // SequencedWorkerPoolTaskRunner --------------------------------------------- 93 // SequencedWorkerPoolTaskRunner ---------------------------------------------
94 // A TaskRunner which posts tasks to a SequencedWorkerPool with a 94 // A TaskRunner which posts tasks to a SequencedWorkerPool with a
95 // fixed ShutdownBehavior. 95 // fixed ShutdownBehavior.
96 // 96 //
97 // Note that this class is RefCountedThreadSafe (inherited from TaskRunner). 97 // Note that this class is RefCountedThreadSafe (inherited from TaskRunner).
98 class SequencedWorkerPoolTaskRunner : public TaskRunner { 98 class SequencedWorkerPoolTaskRunner : public TaskRunner {
99 public: 99 public:
100 SequencedWorkerPoolTaskRunner( 100 SequencedWorkerPoolTaskRunner(
101 const scoped_refptr<SequencedWorkerPool>& pool, 101 scoped_refptr<SequencedWorkerPool> pool,
102 SequencedWorkerPool::WorkerShutdown shutdown_behavior); 102 SequencedWorkerPool::WorkerShutdown shutdown_behavior);
103 103
104 // TaskRunner implementation 104 // TaskRunner implementation
105 bool PostDelayedTask(const tracked_objects::Location& from_here, 105 bool PostDelayedTask(const tracked_objects::Location& from_here,
106 const Closure& task, 106 const Closure& task,
107 TimeDelta delay) override; 107 TimeDelta delay) override;
108 bool RunsTasksOnCurrentThread() const override; 108 bool RunsTasksOnCurrentThread() const override;
109 109
110 private: 110 private:
111 ~SequencedWorkerPoolTaskRunner() override; 111 ~SequencedWorkerPoolTaskRunner() override;
112 112
113 const scoped_refptr<SequencedWorkerPool> pool_; 113 const scoped_refptr<SequencedWorkerPool> pool_;
114 114
115 const SequencedWorkerPool::WorkerShutdown shutdown_behavior_; 115 const SequencedWorkerPool::WorkerShutdown shutdown_behavior_;
116 116
117 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPoolTaskRunner); 117 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPoolTaskRunner);
118 }; 118 };
119 119
120 SequencedWorkerPoolTaskRunner::SequencedWorkerPoolTaskRunner( 120 SequencedWorkerPoolTaskRunner::SequencedWorkerPoolTaskRunner(
121 const scoped_refptr<SequencedWorkerPool>& pool, 121 scoped_refptr<SequencedWorkerPool> pool,
122 SequencedWorkerPool::WorkerShutdown shutdown_behavior) 122 SequencedWorkerPool::WorkerShutdown shutdown_behavior)
123 : pool_(pool), 123 : pool_(std::move(pool)), shutdown_behavior_(shutdown_behavior) {}
124 shutdown_behavior_(shutdown_behavior) {
125 }
126 124
127 SequencedWorkerPoolTaskRunner::~SequencedWorkerPoolTaskRunner() { 125 SequencedWorkerPoolTaskRunner::~SequencedWorkerPoolTaskRunner() {
128 } 126 }
129 127
130 bool SequencedWorkerPoolTaskRunner::PostDelayedTask( 128 bool SequencedWorkerPoolTaskRunner::PostDelayedTask(
131 const tracked_objects::Location& from_here, 129 const tracked_objects::Location& from_here,
132 const Closure& task, 130 const Closure& task,
133 TimeDelta delay) { 131 TimeDelta delay) {
134 if (delay == TimeDelta()) { 132 if (delay == TimeDelta()) {
135 return pool_->PostWorkerTaskWithShutdownBehavior( 133 return pool_->PostWorkerTaskWithShutdownBehavior(
136 from_here, task, shutdown_behavior_); 134 from_here, task, shutdown_behavior_);
137 } 135 }
138 return pool_->PostDelayedWorkerTask(from_here, task, delay); 136 return pool_->PostDelayedWorkerTask(from_here, task, delay);
139 } 137 }
140 138
141 bool SequencedWorkerPoolTaskRunner::RunsTasksOnCurrentThread() const { 139 bool SequencedWorkerPoolTaskRunner::RunsTasksOnCurrentThread() const {
142 return pool_->RunsTasksOnCurrentThread(); 140 return pool_->RunsTasksOnCurrentThread();
143 } 141 }
144 142
145 // SequencedWorkerPoolSequencedTaskRunner ------------------------------------ 143 // SequencedWorkerPoolSequencedTaskRunner ------------------------------------
146 // A SequencedTaskRunner which posts tasks to a SequencedWorkerPool with a 144 // A SequencedTaskRunner which posts tasks to a SequencedWorkerPool with a
147 // fixed sequence token. 145 // fixed sequence token.
148 // 146 //
149 // Note that this class is RefCountedThreadSafe (inherited from TaskRunner). 147 // Note that this class is RefCountedThreadSafe (inherited from TaskRunner).
150 class SequencedWorkerPoolSequencedTaskRunner : public SequencedTaskRunner { 148 class SequencedWorkerPoolSequencedTaskRunner : public SequencedTaskRunner {
151 public: 149 public:
152 SequencedWorkerPoolSequencedTaskRunner( 150 SequencedWorkerPoolSequencedTaskRunner(
153 const scoped_refptr<SequencedWorkerPool>& pool, 151 scoped_refptr<SequencedWorkerPool> pool,
154 SequencedWorkerPool::SequenceToken token, 152 SequencedWorkerPool::SequenceToken token,
155 SequencedWorkerPool::WorkerShutdown shutdown_behavior); 153 SequencedWorkerPool::WorkerShutdown shutdown_behavior);
156 154
157 // TaskRunner implementation 155 // TaskRunner implementation
158 bool PostDelayedTask(const tracked_objects::Location& from_here, 156 bool PostDelayedTask(const tracked_objects::Location& from_here,
159 const Closure& task, 157 const Closure& task,
160 TimeDelta delay) override; 158 TimeDelta delay) override;
161 bool RunsTasksOnCurrentThread() const override; 159 bool RunsTasksOnCurrentThread() const override;
162 160
163 // SequencedTaskRunner implementation 161 // SequencedTaskRunner implementation
164 bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here, 162 bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here,
165 const Closure& task, 163 const Closure& task,
166 TimeDelta delay) override; 164 TimeDelta delay) override;
167 165
168 private: 166 private:
169 ~SequencedWorkerPoolSequencedTaskRunner() override; 167 ~SequencedWorkerPoolSequencedTaskRunner() override;
170 168
171 const scoped_refptr<SequencedWorkerPool> pool_; 169 const scoped_refptr<SequencedWorkerPool> pool_;
172 170
173 const SequencedWorkerPool::SequenceToken token_; 171 const SequencedWorkerPool::SequenceToken token_;
174 172
175 const SequencedWorkerPool::WorkerShutdown shutdown_behavior_; 173 const SequencedWorkerPool::WorkerShutdown shutdown_behavior_;
176 174
177 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPoolSequencedTaskRunner); 175 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPoolSequencedTaskRunner);
178 }; 176 };
179 177
180 SequencedWorkerPoolSequencedTaskRunner::SequencedWorkerPoolSequencedTaskRunner( 178 SequencedWorkerPoolSequencedTaskRunner::SequencedWorkerPoolSequencedTaskRunner(
181 const scoped_refptr<SequencedWorkerPool>& pool, 179 scoped_refptr<SequencedWorkerPool> pool,
182 SequencedWorkerPool::SequenceToken token, 180 SequencedWorkerPool::SequenceToken token,
183 SequencedWorkerPool::WorkerShutdown shutdown_behavior) 181 SequencedWorkerPool::WorkerShutdown shutdown_behavior)
184 : pool_(pool), 182 : pool_(std::move(pool)),
185 token_(token), 183 token_(token),
186 shutdown_behavior_(shutdown_behavior) { 184 shutdown_behavior_(shutdown_behavior) {}
187 }
188 185
189 SequencedWorkerPoolSequencedTaskRunner:: 186 SequencedWorkerPoolSequencedTaskRunner::
190 ~SequencedWorkerPoolSequencedTaskRunner() { 187 ~SequencedWorkerPoolSequencedTaskRunner() {
191 } 188 }
192 189
193 bool SequencedWorkerPoolSequencedTaskRunner::PostDelayedTask( 190 bool SequencedWorkerPoolSequencedTaskRunner::PostDelayedTask(
194 const tracked_objects::Location& from_here, 191 const tracked_objects::Location& from_here,
195 const Closure& task, 192 const Closure& task,
196 TimeDelta delay) { 193 TimeDelta delay) {
197 if (delay == TimeDelta()) { 194 if (delay == TimeDelta()) {
(...skipping 25 matching lines...) Expand all
223 } 220 }
224 221
225 } // namespace 222 } // namespace
226 223
227 // Worker --------------------------------------------------------------------- 224 // Worker ---------------------------------------------------------------------
228 225
229 class SequencedWorkerPool::Worker : public SimpleThread { 226 class SequencedWorkerPool::Worker : public SimpleThread {
230 public: 227 public:
231 // Hold a (cyclic) ref to |worker_pool|, since we want to keep it 228 // Hold a (cyclic) ref to |worker_pool|, since we want to keep it
232 // around as long as we are running. 229 // around as long as we are running.
233 Worker(const scoped_refptr<SequencedWorkerPool>& worker_pool, 230 Worker(scoped_refptr<SequencedWorkerPool> worker_pool,
234 int thread_number, 231 int thread_number,
235 const std::string& thread_name_prefix); 232 const std::string& thread_name_prefix);
236 ~Worker() override; 233 ~Worker() override;
237 234
238 // SimpleThread implementation. This actually runs the background thread. 235 // SimpleThread implementation. This actually runs the background thread.
239 void Run() override; 236 void Run() override;
240 237
241 // Gets the worker for the current thread out of thread-local storage. 238 // Gets the worker for the current thread out of thread-local storage.
242 static Worker* GetForCurrentThread(); 239 static Worker* GetForCurrentThread();
243 240
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 ConditionVariable cleanup_cv_; 494 ConditionVariable cleanup_cv_;
498 495
499 TestingObserver* const testing_observer_; 496 TestingObserver* const testing_observer_;
500 497
501 DISALLOW_COPY_AND_ASSIGN(Inner); 498 DISALLOW_COPY_AND_ASSIGN(Inner);
502 }; 499 };
503 500
504 // Worker definitions --------------------------------------------------------- 501 // Worker definitions ---------------------------------------------------------
505 502
506 SequencedWorkerPool::Worker::Worker( 503 SequencedWorkerPool::Worker::Worker(
507 const scoped_refptr<SequencedWorkerPool>& worker_pool, 504 scoped_refptr<SequencedWorkerPool> worker_pool,
508 int thread_number, 505 int thread_number,
509 const std::string& prefix) 506 const std::string& prefix)
510 : SimpleThread(prefix + StringPrintf("Worker%d", thread_number)), 507 : SimpleThread(prefix + StringPrintf("Worker%d", thread_number)),
511 worker_pool_(worker_pool), 508 worker_pool_(std::move(worker_pool)),
512 task_shutdown_behavior_(BLOCK_SHUTDOWN), 509 task_shutdown_behavior_(BLOCK_SHUTDOWN),
513 is_processing_task_(false) { 510 is_processing_task_(false) {
514 Start(); 511 Start();
515 } 512 }
516 513
517 SequencedWorkerPool::Worker::~Worker() { 514 SequencedWorkerPool::Worker::~Worker() {
518 } 515 }
519 516
520 void SequencedWorkerPool::Worker::Run() { 517 void SequencedWorkerPool::Worker::Run() {
521 #if defined(OS_WIN) 518 #if defined(OS_WIN)
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
1398 void SequencedWorkerPool::Shutdown(int max_new_blocking_tasks_after_shutdown) { 1395 void SequencedWorkerPool::Shutdown(int max_new_blocking_tasks_after_shutdown) {
1399 DCHECK(constructor_task_runner_->BelongsToCurrentThread()); 1396 DCHECK(constructor_task_runner_->BelongsToCurrentThread());
1400 inner_->Shutdown(max_new_blocking_tasks_after_shutdown); 1397 inner_->Shutdown(max_new_blocking_tasks_after_shutdown);
1401 } 1398 }
1402 1399
1403 bool SequencedWorkerPool::IsShutdownInProgress() { 1400 bool SequencedWorkerPool::IsShutdownInProgress() {
1404 return inner_->IsShutdownInProgress(); 1401 return inner_->IsShutdownInProgress();
1405 } 1402 }
1406 1403
1407 } // namespace base 1404 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698