Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 1800723002: Simplify checking for prefetch field trial in RDH (Closed)

Created:
4 years, 9 months ago by pasko
Modified:
4 years, 9 months ago
CC:
chromium-reviews, gavinp
Base URL:
https://chromium.googlesource.com/chromium/src.git@link-rel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify checking for prefetch field trial in RDH BUG=589369 Committed: https://crrev.com/a8dd03e75f6615ffcebbf95a3898377765e39961 Cr-Commit-Position: refs/heads/master@{#381936}

Patch Set 1 #

Patch Set 2 : prefetch.h #

Patch Set 3 : rebased on top of master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -84 lines) Patch
D chrome/browser/prefetch/prefetch.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/prefetch/prefetch.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/prefetch/prefetch_field_trial.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/prefetch/prefetch_field_trial.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
pasko
okay, trybots cannot test modify&delete dependencies, waiting for the upstream patch to land
4 years, 9 months ago (2016-03-14 18:29:52 UTC) #1
pasko
nasko: please review changes in chrome_resource_dispatcher_host_delegate.cc (though I am surprised why you are not a ...
4 years, 9 months ago (2016-03-15 16:58:37 UTC) #3
nasko
Non-ownerLGTM
4 years, 9 months ago (2016-03-16 18:14:10 UTC) #4
nasko
On 2016/03/16 18:14:10, nasko (slow) wrote: > Non-ownerLGTM Argh! Keyboard error. LGTM
4 years, 9 months ago (2016-03-16 18:14:23 UTC) #5
pasko
jochen@chromium.org: PTaL Now that nasko@ approves, this should be a relaxing review, almost like rubberstamp.
4 years, 9 months ago (2016-03-16 18:21:36 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-17 19:55:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800723002/40001
4 years, 9 months ago (2016-03-18 09:46:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 11:13:00 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 11:14:23 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8dd03e75f6615ffcebbf95a3898377765e39961
Cr-Commit-Position: refs/heads/master@{#381936}

Powered by Google App Engine
This is Rietveld 408576698