Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1800703002: Forward visibility explicitly in GN component. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward visibility explicitly in GN component. As described in the added comment, this picks up file-scope visibility in components, where before it did not apply. Fixes //ui/ozone:ozone's visibility which was not being applied because of this. I believe the intent of the ozone target is to be public and the rest should be file-local. BUG=594610 Committed: https://crrev.com/58c2b3a90b634d71ccc8de68417789f21a59a6eb Cr-Commit-Position: refs/heads/master@{#381043}

Patch Set 1 #

Patch Set 2 : ozone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +9 lines, -1 line 0 comments Download
M ui/ozone/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
4 years, 9 months ago (2016-03-14 18:11:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800703002/1
4 years, 9 months ago (2016-03-14 18:12:04 UTC) #4
yzshen1
lgtm
4 years, 9 months ago (2016-03-14 18:13:03 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/129698)
4 years, 9 months ago (2016-03-14 18:20:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800703002/20001
4 years, 9 months ago (2016-03-14 18:25:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 19:36:08 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:37:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58c2b3a90b634d71ccc8de68417789f21a59a6eb
Cr-Commit-Position: refs/heads/master@{#381043}

Powered by Google App Engine
This is Rietveld 408576698