Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1800683002: Fix the imported package library move test. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the imported package library move test. Files in package lib/ folders have package: URI scheme, so the test should use it too. This CL finishes fixing tests that were failing with the new index. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/feae2ba7c95e4a9c73f8dbb72749878effc93e43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 2 chunks +32 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-14 16:01:36 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-14 16:03:55 UTC) #2
scheglov
4 years, 9 months ago (2016-03-14 16:05:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
feae2ba7c95e4a9c73f8dbb72749878effc93e43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698