Issue 180063003: allow skia flags to be specified in a skia file, but reference by chrome's skia_common.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180063003: allow skia flags to be specified in a skia file, but reference by chrome's skia_common.gypi (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 10 months ago

Reviewers:
bungeman-skia, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

allow skia flags to be specified in a skia file, but reference by chrome's skia_common.gypi in support of https://codereview.chromium.org/180083002/ which will land after this CL is visible in Chrome R=bungeman@google.com Committed: https://code.google.com/p/skia/source/detail?r=13582

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	A	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

6 years, 10 months ago (2014-02-25 18:13:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13582 (presubmit successful).