Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1800623002: GrTessellator: don't reuse the previous vertex buffer on a cache miss. (Closed)

Created:
4 years, 9 months ago by Stephen White
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrTessellator: don't reuse the previous vertex buffer on a cache miss. Just let the cache give us the correct entry for the given size. This simplifies the code (no mysterious non-const ref member). I don't see any performance effect from this change, but will watch the bots closely. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1800623002 Committed: https://skia.googlesource.com/skia/+/af1e21e7ebb155d2505da0eb974c672953dfefef

Patch Set 1 #

Patch Set 2 : Cleanup; style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 4 chunks +13 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800623002/20001
4 years, 9 months ago (2016-03-14 15:40:08 UTC) #3
Stephen White
Brian: PTAL. Thanks!
4 years, 9 months ago (2016-03-14 15:42:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-14 15:48:39 UTC) #8
Stephen White
bsalomon: ping? (it's small)
4 years, 9 months ago (2016-03-15 20:44:05 UTC) #9
bsalomon
On 2016/03/15 20:44:05, Stephen White wrote: > bsalomon: ping? (it's small) lgtm (sorry was OOO ...
4 years, 9 months ago (2016-03-16 14:01:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800623002/20001
4 years, 9 months ago (2016-03-16 17:01:18 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:26:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af1e21e7ebb155d2505da0eb974c672953dfefef

Powered by Google App Engine
This is Rietveld 408576698