chrome/browser/nacl_host/nacl_browser_delegate_impl.cc - Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more cleanup Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/pnacl/pnacl_updater_observer.cc ('K') | « chrome/browser/component_updater/pnacl/pnacl_updater_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

diff --git a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc b/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

index 9e17b2f524ab2d7e71179aa08d858653043613ef..eec61e5188f97faa0d447fb9eb4e08c7e1b6f90b 100644

--- a/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

+++ b/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc

@@ -61,8 +61,10 @@ ppapi::host::HostFactory* NaClBrowserDelegateImpl::CreatePpapiHostFactory(

void NaClBrowserDelegateImpl::TryInstallPnacl(

const base::Callback<void(bool)>& installed) {

- ComponentUpdateService* cus = g_browser_process->component_updater();

PnaclComponentInstaller* pci =

g_browser_process->pnacl_component_installer();

- RequestFirstInstall(cus, pci, installed);

+ if (pci)

+ pci->RequestFirstInstall(installed);

+ else

+ installed.Run(false);

}

« chrome/browser/component_updater/pnacl/pnacl_updater_observer.cc ('K') | « chrome/browser/component_updater/pnacl/pnacl_updater_observer.cc ('k') | no next file » | no next file with comments »