Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: chrome/browser/component_updater/component_updater_service.cc

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sorins review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.cc
diff --git a/chrome/browser/component_updater/component_updater_service.cc b/chrome/browser/component_updater/component_updater_service.cc
index 804885582df9a2b4c893b5fc161e377c760fa879..fb709a1739e6ffad5d3e638652a4be275d97d189 100644
--- a/chrome/browser/component_updater/component_updater_service.cc
+++ b/chrome/browser/component_updater/component_updater_service.cc
@@ -311,6 +311,9 @@ class CrxUpdateService : public ComponentUpdateService {
virtual Status Stop() OVERRIDE;
virtual Status RegisterComponent(const CrxComponent& component) OVERRIDE;
virtual Status CheckForUpdateSoon(const CrxComponent& component) OVERRIDE;
+ virtual bool IsUpdateNotificationForComponent(
+ const content::NotificationSource& source,
+ const CrxComponent& component) OVERRIDE;
// The only purpose of this class is to forward the
// UtilityProcessHostClient callbacks so CrxUpdateService does
@@ -984,6 +987,15 @@ void CrxUpdateService::DoneInstalling(const std::string& component_id,
ScheduleNextRun(false);
}
+bool CrxUpdateService::IsUpdateNotificationForComponent(
Sorin Jianu 2013/07/03 23:10:04 What is strange about this function is that is see
jvoung (off chromium) 2013/07/04 01:11:04 One argument for having it be a member function, i
+ const content::NotificationSource& src,
+ const CrxComponent& component) {
+ std::string id =
+ HexStringToID(StringToLowerASCII(base::HexEncode(&component.pk_hash[0],
+ component.pk_hash.size()/2)));
+ return content::Source<std::string>(src)->compare(id) == 0;
+}
+
// The component update factory. Using the component updater as a singleton
// is the job of the browser process.
ComponentUpdateService* ComponentUpdateServiceFactory(

Powered by Google App Engine
This is Rietveld 408576698