Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.h
diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
index 88fb61fb823b7290114296b8d4f1524afaf40b9e..18d2b1e31e4987fc19d5f3ed07c8b23a3d06bc11 100644
--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
@@ -47,6 +47,8 @@ class PnaclComponentInstaller : public ComponentInstaller {
// updater service.
void ReRegisterPnacl();
+ CrxComponent GetCrxComponent();
Sorin Jianu 2013/07/03 21:17:32 could declare the function const.
jvoung (off chromium) 2013/07/03 22:51:51 Done. It does introduce a const-cast when taking
+
// Return true if PNaCl installs are separated by user.
bool per_user() const { return per_user_; }
@@ -84,10 +86,8 @@ class PnaclComponentInstaller : public ComponentInstaller {
base::FilePath current_profile_path_;
base::Version current_version_;
ComponentUpdateService* cus_;
- // Counter to issue identifiers to each callback.
- int callback_nums_;
// List of callbacks to issue when an install completes successfully.
- std::list<std::pair<InstallCallback, int> > install_callbacks_;
+ std::list<InstallCallback> install_callbacks_;
// Component updater service observer, to determine when an on-demand
// install request failed.
scoped_ptr<PnaclUpdaterObserver> updater_observer_;

Powered by Google App Engine
This is Rietveld 408576698