Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: chrome/browser/component_updater/component_updater_service.cc

Issue 18006003: Consistently use notifications from component updater w/ on-demand PNaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup test a bit Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.cc
diff --git a/chrome/browser/component_updater/component_updater_service.cc b/chrome/browser/component_updater/component_updater_service.cc
index 6be2c039fe7ae8904d7ba35498cf04c7f8e3aea2..09c61c131297708f7bda03205adc9710a96d79e7 100644
--- a/chrome/browser/component_updater/component_updater_service.cc
+++ b/chrome/browser/component_updater/component_updater_service.cc
@@ -853,7 +853,7 @@ void CrxUpdateService::OnParseUpdateManifestSucceeded(
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_COMPONENT_UPDATE_FOUND,
- content::Source<std::string>(&crx->id),
+ content::Source<UpdateSource>(&crx->id),
content::NotificationService::NoDetails());
}
@@ -921,7 +921,7 @@ void CrxUpdateService::OnURLFetchComplete(const net::URLFetcher* source,
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_COMPONENT_UPDATE_READY,
- content::Source<std::string>(&context->id),
+ content::Source<UpdateSource>(&context->id),
content::NotificationService::NoDetails());
// Why unretained? See comment at top of file.
@@ -1004,6 +1004,15 @@ void CrxUpdateService::DoneInstalling(const std::string& component_id,
ScheduleNextRun(false);
}
+bool ComponentUpdateService::IsUpdateNotificationForComponent(
+ const content::NotificationSource& src,
+ const CrxComponent& component) {
+ std::string id =
+ HexStringToID(StringToLowerASCII(base::HexEncode(&component.pk_hash[0],
+ component.pk_hash.size()/2)));
+ return content::Source<UpdateSource>(src)->compare(id) == 0;
+}
+
// The component update factory. Using the component updater as a singleton
// is the job of the browser process.
ComponentUpdateService* ComponentUpdateServiceFactory(

Powered by Google App Engine
This is Rietveld 408576698